feat: .NET 11 (#339)

Migrates the backend from .NET 10 to .NET 11 (SDK 11.0.100-rc.1), and drops the
OneOf package in favour of the language's own discriminated unions.

- Targets net11.0 with LangVersion=preview and <Features>runtime-async=on</Features>.
- Replaces OneOf<T0..Tn> with C# `union` types declared in Common/Results/Unions.cs,
  plus the case markers in Common/Results/CommonResultCases.cs. All ~30 call sites
  move from .Match/.TryPickT0/.IsT0/.AsT0 to pattern matching. Non-exhaustive
  switches over a union carry `default: throw new UnreachableException()`, since a
  switch statement is not exhaustiveness-checked.
- Bumps ASP.NET Core, EF Core, Npgsql and DataProtection to 11.0.0-rc.1, and
  OpenShock.Internal.* to 1.2.0. Microsoft.AspNetCore.OpenApi goes to 11.x, which
  needs Microsoft.OpenApi 3.x and so trips NU1608 against Asp.Versioning.OpenApi's
  <3.0.0 constraint; verified working (the generated document is unchanged bar 9
  schemas gaining a correct "type": "object"), so NU1608 is demoted to a warning
  rather than suppressed.
- Pins StackExchange.Redis 3.2.15: 3.0.25 reflects over a MulticastDelegate field
  that no longer exists on .NET 11 and aborts the process.
- Moves the docker images to rc.1 and copies global.json into the build stage, so
  the SDK pin is enforced there instead of silently falling back to whatever the
  base image ships.
- Converts the configuration service's TryGet*Async to ConfigGetResult<T>, and the
  Cron email template parser from throwing to returning an error case.

68 files, +710/-503. 311 tests pass.

Author: hhvrc

.dockerignore

@@ -9,4 +9,4 @@ API/SmtpTemplates/dist/
 **/appsettings.Development.json
 Dockerfile*
 **/*.md
-dev/
+Dev/

.github/workflows/ci-build.yml

@@ -23,7 +23,7 @@ name: ci-build
 
 env:
   REGISTRY: ghcr.io
-  DOTNET_VERSION: 10.0.x
+  DOTNET_VERSION: 11.0.x
 
 jobs:
 

.github/workflows/ci-tag.yml

@@ -7,7 +7,7 @@ on:
 name: ci-tag
 
 env:
-  DOTNET_VERSION: 10.0.x
+  DOTNET_VERSION: 11.0.x
   REGISTRY: ghcr.io
   IMAGE_NAME: ${{ github.repository_owner }}/api
 

.github/workflows/codeql.yml

@@ -9,7 +9,7 @@ on:
     - cron: '0 6 * * 1'
 
 env:
-  DOTNET_VERSION: 10.x.x
+  DOTNET_VERSION: 11.0.x
 
 jobs:
   analyze:

API/Controller/Account/Authenticated/ChangeEmail.cs

@@ -2,9 +2,11 @@
 using System.Net.Mime;
 using Microsoft.AspNetCore.Mvc;
 using OpenShock.API.Models.Requests;
+using OpenShock.API.Services.Account;
 using OpenShock.Common.Errors;
 using OpenShock.Common.Problems;
 using OpenShock.Common.Utils;
+using Results = OpenShock.Common.Results;
 
 using OpenShock.Internal.Common.Utils;
 
@@ -42,13 +44,16 @@ public async Task<IActionResult> ChangeEmail([FromBody] ChangeEmailRequest body)
 
         var result = await _accountService.CreateEmailChangeFlowAsync(CurrentUser.Id, body.Email, actorId: CurrentUser.Id);
 
-        return result.Match<IActionResult>(
-            success => Ok(),
-            alreadyInUse => Problem(AccountError.EmailChangeAlreadyInUse),
-            unchanged => Problem(AccountError.EmailChangeUnchanged),
-            tooMany => Problem(AccountError.EmailChangeTooMany),
-            notActivated => throw new UnreachableException("Authenticated user is not activated"),
-            deactivated => throw new UnreachableException("Authenticated user is deactivated"),
-            notFound => throw new UnreachableException("Authenticated user not found in database"));
+        return result switch
+        {
+            Results.Success => Ok(),
+            EmailAlreadyInUse => Problem(AccountError.EmailChangeAlreadyInUse),
+            EmailUnchanged => Problem(AccountError.EmailChangeUnchanged),
+            TooManyEmailChanges => Problem(AccountError.EmailChangeTooMany),
+            AccountNotActivated => throw new UnreachableException("Authenticated user is not activated"),
+            AccountDeactivated => throw new UnreachableException("Authenticated user is deactivated"),
+            Results.NotFound => throw new UnreachableException("Authenticated user not found in database"),
+            _ => throw new UnreachableException()
+        };
     }
 }

API/Controller/Account/Authenticated/ChangePassword.cs

@@ -2,9 +2,11 @@
 using System.Net.Mime;
 using Microsoft.AspNetCore.Mvc;
 using OpenShock.API.Models.Requests;
+using OpenShock.API.Services.Account;
 using OpenShock.Common.Errors;
 using OpenShock.Common.Problems;
 using OpenShock.Common.Utils;
+using Results = OpenShock.Common.Results;
 
 using OpenShock.Internal.Common.Utils;
 
@@ -42,10 +44,13 @@ public async Task<IActionResult> ChangePassword([FromBody] ChangePasswordRequest
 
         var result = await _accountService.ChangePasswordAsync(CurrentUser.Id, body.NewPassword, actorId: CurrentUser.Id);
 
-        return result.Match<IActionResult>(
-            success => Ok(),
-            notActivated => throw new UnreachableException("Authenticated user is not activated"),
-            deactivated => throw new UnreachableException("Authenticated user is deactivated"),
-            notFound => throw new UnreachableException("Authenticated user not found in database"));
+        return result switch
+        {
+            Results.Success => Ok(),
+            AccountNotActivated => throw new UnreachableException("Authenticated user is not activated"),
+            AccountDeactivated => throw new UnreachableException("Authenticated user is deactivated"),
+            Results.NotFound => throw new UnreachableException("Authenticated user not found in database"),
+            _ => throw new UnreachableException()
+        };
     }
 }

API/Controller/Account/Authenticated/ChangeUsername.cs

@@ -1,9 +1,13 @@
-using System.Net.Mime;
+using System.Diagnostics;
+using System.Net.Mime;
 using Microsoft.AspNetCore.Mvc;
 using OpenShock.API.Models.Requests;
+using OpenShock.API.Services.Account;
 using OpenShock.Common.Errors;
 using OpenShock.Common.OpenShockDb;
 using OpenShock.Common.Problems;
+using OpenShock.Common.Validation;
+using Results = OpenShock.Common.Results;
 
 using OpenShock.Internal.Common.Problems;
 
@@ -28,12 +32,15 @@ public async Task<IActionResult> ChangeUsername([FromBody] ChangeUsernameRequest
         var result = await _accountService.ChangeUsernameAsync(CurrentUser.Id, body.Username, actorId: CurrentUser.Id,
             ignoreLimit: CurrentUser.Roles.Any(r => r is RoleType.Staff or RoleType.Admin or RoleType.System));
 
-        return result.Match<IActionResult>(
-            success => Ok(),
-            usernametaken => Problem(AccountError.UsernameTaken),
-            usernameerror => Problem(AccountError.UsernameInvalid(usernameerror)),
-            recentlychanged => Problem(AccountError.UsernameRecentlyChanged),
-            accountdeactivated => Problem(AccountError.AccountDeactivated),
-            notfound => throw new Exception("Unexpected result, apparently our current user does not exist..."));
+        return result switch
+        {
+            Results.Success => Ok(),
+            UsernameTaken => Problem(AccountError.UsernameTaken),
+            UsernameError usernameError => Problem(AccountError.UsernameInvalid(usernameError)),
+            RecentlyChanged => Problem(AccountError.UsernameRecentlyChanged),
+            AccountDeactivated => Problem(AccountError.AccountDeactivated),
+            Results.NotFound => throw new Exception("Unexpected result, apparently our current user does not exist..."),
+            _ => throw new UnreachableException()
+        };
     }
 }

API/Controller/Account/Authenticated/Deactivate.cs

@@ -1,7 +1,11 @@
 using Microsoft.AspNetCore.Mvc;
+using System.Diagnostics;
 using System.Net.Mime;
+using OpenShock.API.Services.Account;
 using OpenShock.Common.Errors;
 using OpenShock.Common.Problems;
+using AccountSvc = OpenShock.API.Services.Account;
+using Results = OpenShock.Common.Results;
 
 using OpenShock.Internal.Common.Problems;
 
@@ -19,12 +23,14 @@ public sealed partial class AuthenticatedAccountController
     public async Task<IActionResult> Deactivate()
     {
         var deactivationResult = await _accountService.DeactivateAccountAsync(CurrentUser.Id, CurrentUser.Id, deleteLater: true);
-        return deactivationResult.Match<IActionResult>(
-            success => NoContent(),
-            cannotDeactivatePrivledged => Problem(AccountActivationError.CannotDeactivateOrDeletePrivledgedAccount),
-            alreadyDeactivated => Problem(AccountActivationError.AlreadyDeactivated),
-            unauthorized => Problem(AccountActivationError.Unauthorized),
-            notFound => throw new Exception("This is not supposed to happen, wtf?")
-        );
+        return deactivationResult switch
+        {
+            Results.Success => NoContent(),
+            CannotDeactivatePrivilegedAccount => Problem(AccountActivationError.CannotDeactivateOrDeletePrivledgedAccount),
+            AccountDeactivationAlreadyInProgress => Problem(AccountActivationError.AlreadyDeactivated),
+            AccountSvc.Unauthorized => Problem(AccountActivationError.Unauthorized),
+            Results.NotFound => throw new Exception("This is not supposed to happen, wtf?"),
+            _ => throw new UnreachableException()
+        };
     }
 }

API/Controller/Account/CheckUsername.cs

@@ -1,7 +1,10 @@
-using System.Diagnostics.CodeAnalysis;
+using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Net.Mime;
 using Microsoft.AspNetCore.Mvc;
 using OpenShock.API.Models.Requests;
+using OpenShock.API.Services.Account;
+using OpenShock.Common.Results;
 using OpenShock.Common.Validation;
 
 namespace OpenShock.API.Controller.Account;
@@ -20,11 +23,13 @@ public async Task<UsernameCheckResponse> CheckUsername([FromBody] ChangeUsername
     {
         var result = await _accountService.CheckUsernameAvailabilityAsync(body.Username, cancellationToken);
 
-        return result.Match(
-            success => new UsernameCheckResponse(UsernameAvailability.Available),
-            taken => new UsernameCheckResponse(UsernameAvailability.Taken),
-            invalid => new UsernameCheckResponse(UsernameAvailability.Invalid, invalid)
-        );
+        return result switch
+        {
+            Success => new UsernameCheckResponse(UsernameAvailability.Available),
+            UsernameTaken => new UsernameCheckResponse(UsernameAvailability.Taken),
+            UsernameError invalid => new UsernameCheckResponse(UsernameAvailability.Invalid, invalid),
+            _ => throw new UnreachableException()
+        };
     }
 }
 

API/Controller/Account/LoginV2.cs

@@ -1,12 +1,16 @@
 using Microsoft.AspNetCore.Mvc;
 using OpenShock.API.Models.Requests;
+using System.Diagnostics;
 using System.Net.Mime;
 using Asp.Versioning;
 using Microsoft.AspNetCore.RateLimiting;
+using OpenShock.API.Services.Account;
 using OpenShock.Common.Errors;
+using OpenShock.Common.OpenShockDb;
 using OpenShock.Common.Problems;
 using OpenShock.API.Models.Response;
 using OpenShock.API.Services.Turnstile;
+using Results = OpenShock.Common.Results;
 
 using OpenShock.Internal.Common.Problems;
 
@@ -38,14 +42,16 @@ public async Task<IActionResult> LoginV2(
         if (turnstileError is not null) return turnstileError;
 
         var getAccountResult = await _accountService.GetAccountByCredentialsAsync(body.UsernameOrEmail, body.Password, cancellationToken);
-        if (!getAccountResult.TryPickT0(out var account, out var errors))
+        if (getAccountResult is not User account)
         {
-            return errors.Match(
-                notFound => Problem(LoginError.InvalidCredentials),
-                deactivated => Problem(AccountError.AccountDeactivated),
-                notActivated => Problem(AccountError.AccountNotActivated),
-                oauthOnly => Problem(AccountError.AccountOAuthOnly)
-            );
+            return getAccountResult switch
+            {
+                Results.NotFound => Problem(LoginError.InvalidCredentials),
+                AccountDeactivated => Problem(AccountError.AccountDeactivated),
+                AccountNotActivated => Problem(AccountError.AccountNotActivated),
+                AccountIsOAuthOnly => Problem(AccountError.AccountOAuthOnly),
+                _ => throw new UnreachableException()
+            };
         }
 
         await CreateSession(account.Id, cookieDomain);