fix: return type for ip should be a string

Author: LucHeart

API/Controller/Admin/GetOnlineDevices.cs

@@ -1,5 +1,4 @@
-using System.Net;
-using System.Net.Mime;
+using System.Net.Mime;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.EntityFrameworkCore;
 using OpenShock.Common.Extensions;
@@ -82,6 +81,6 @@ public sealed class AdminOnlineDeviceResponse
         public required ushort? LatencyMs { get; init; }
         public required int? Rssi { get; init; }
         public required string? Country { get; set; }
-        public required IPAddress? Ip { get; set; }
+        public required string? Ip { get; set; }
     }
 }

Common/Redis/DeviceOnline.cs

@@ -1,5 +1,4 @@
-using System.Net;
-using System.Text.Json.Serialization;
+using System.Text.Json.Serialization;
 using OpenShock.Common.JsonSerialization;
 using OpenShock.Common.Models;
 using Redis.OM.Modeling;
@@ -23,5 +22,5 @@ public sealed class DeviceOnline
     public ushort? LatencyMs { get; set; }
     public int? Rssi { get; set; }
     public string? Country { get; set; }
-    public IPAddress? Ip { get; set; }
+    public string? Ip { get; set; }
 }

LiveControlGateway/LifetimeManager/HubLifetime.cs

@@ -500,13 +500,9 @@ public async Task<OneOf<Success, OnlineStateUpdated>> Online(Guid device, SelfOn
         online.BootedAt = data.BootedAt;
         online.LatencyMs = data.LatencyMs;
         online.Rssi = data.Rssi;
-        online.Gateway = data.Gateway;
-        online.FirmwareVersion = data.FirmwareVersion;
-        online.ConnectedAt = data.ConnectedAt;
-        online.UserAgent = data.UserAgent;
         online.Country = data.Country;
-        online.Ip = data.Ip;
-        
+        online.Ip = data.Ip?.ToString();
+
         var sendOnlineStatusUpdate = false;
 
         // Do we need to send a update to the clients?
@@ -515,6 +511,11 @@ public async Task<OneOf<Success, OnlineStateUpdated>> Online(Guid device, SelfOn
             online.ConnectedAt != data.ConnectedAt ||
             online.UserAgent != data.UserAgent)
         {
+            online.Gateway = data.Gateway;
+            online.FirmwareVersion = data.FirmwareVersion;
+            online.ConnectedAt = data.ConnectedAt;
+            online.UserAgent = data.UserAgent;
+
             sendOnlineStatusUpdate = true;
         }
 
@@ -554,6 +555,8 @@ await deviceOnline.InsertAsync(new DeviceOnline
                 BootedAt = data.BootedAt,
                 LatencyMs = data.LatencyMs,
                 Rssi = data.Rssi,
+                Country = data.Country,
+                Ip = data.Ip?.ToString(),
             }, Duration.DeviceKeepAliveTimeout);
         }
     }