From 96fbca5e1b7736ba43264b7d3fa77a3a351f3cf4 Mon Sep 17 00:00:00 2001 From: Aisha Hassen <167166847+AishaHassen@users.noreply.github.com> Date: Mon, 2 Feb 2026 13:07:02 +0300 Subject: [PATCH 1/7] Enhance feature request template with QA criteria Added QA acceptance criteria checklist for feature requests. --- .github/ISSUE_TEMPLATE/feature-request.md | 33 +++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md index 7f1e10d..74ebcd2 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -91,3 +91,36 @@ checked: - [ ] Workflow Diagrams: Ensure workflow diagrams are complete and linked. - [ ] VPN Access: Ensure VPN Access is provided if required to run the workflow - [ ] Toggl: Ensure the Toggl project name is provided. + +## QA Acceptance Criteria + +Before marking this issue as ready for review, complete the following checklist: + +### 1. Spec Validation +- [ ] All jobs from the specification are implemented in the workflow YAML +- [ ] Job logic matches specification requirements (conditional paths, transformations) +- [ ] Edge cases are handled (empty arrays, null values, missing optional fields) + +### 2. Technical Validation +- [ ] Workflow executes successfully with test data +- [ ] Each job works correctly in isolation +- [ ] `state.data` is cleaned up at the end of each job (only data needed for next job is retained) +- [ ] Null/undefined scenarios are handled gracefully + +### 3. Target System Verification +- [ ] Logged into target system and manually verified created/updated records +- [ ] Verified field-level mapping accuracy for all mapped fields (not just record existence) +- [ ] Confirmed relationships/references are correctly established +- [ ] Checked audit trails (if available) + +### 4. Test Coverage +- [ ] Tested new record creation +- [ ] Tested update of existing records (if applicable) +- [ ] Tested duplicate handling +- [ ] Tested with missing optional fields +- [ ] Tested with missing required fields (fails gracefully) + +### 5. Documentation +- [ ] Documented test data used (with IDs for reuse) +- [ ] Documented any known issues or limitations +- [ ] Documented assumptions made during implementation From fd88783496eb54ab03d676354995465bb223b997 Mon Sep 17 00:00:00 2001 From: Aisha Hassen <167166847+AishaHassen@users.noreply.github.com> Date: Mon, 2 Feb 2026 13:30:23 +0300 Subject: [PATCH 2/7] Enhance bug report template with QA criteria Added QA acceptance criteria section with detailed checklist for validation and documentation. --- .github/ISSUE_TEMPLATE/bug_report.md | 33 ++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index eda5841..b659333 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -46,6 +46,39 @@ data to help the dev validate the implementation. `Name of Toggl project` +## QA Acceptance Criteria + +Before marking this issue as ready for review, complete the following checklist: + +### 1. Spec Validation +- [ ] All jobs from the specification are implemented in the workflow YAML +- [ ] Job logic matches specification requirements (conditional paths, transformations) +- [ ] Edge cases are handled (empty arrays, null values, missing optional fields) + +### 2. Technical Validation +- [ ] Workflow executes successfully with test data +- [ ] Each job works correctly in isolation +- [ ] `state.data` is cleaned up at the end of each job (only data needed for next job is retained) +- [ ] Null/undefined scenarios are handled gracefully + +### 3. Target System Verification +- [ ] Logged into target system and manually verified created/updated records +- [ ] Verified field-level mapping accuracy for all mapped fields (not just record existence) +- [ ] Confirmed relationships/references are correctly established +- [ ] Checked audit trails (if available) + +### 4. Test Coverage +- [ ] Tested new record creation +- [ ] Tested update of existing records (if applicable) +- [ ] Tested duplicate handling +- [ ] Tested with missing optional fields +- [ ] Tested with missing required fields (fails gracefully) + +### 5. Documentation +- [ ] Documented test data used (with IDs for reuse) +- [ ] Documented any known issues or limitations +- [ ] Documented assumptions made during implementation + ## Pre-Development Checklist Before handling this issue to a developer, ensure the following items are From 4be718d31a54daa23a148e2af3d8f20122d365bb Mon Sep 17 00:00:00 2001 From: Aisha Hassen <167166847+AishaHassen@users.noreply.github.com> Date: Mon, 2 Feb 2026 13:30:52 +0300 Subject: [PATCH 3/7] Reorganize Pre-Development Checklist in feature request template Moved the Pre-Development Checklist section to a new location for better organization. --- .github/ISSUE_TEMPLATE/feature-request.md | 36 +++++++++++------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md index 74ebcd2..6ed7035 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -74,24 +74,6 @@ data to help the dev validate the implementation. `Name of Toggl project` -## Pre-Development Checklist - -Before handling this issue to a developer, ensure the following items are -checked: - -- [ ] Credentials: Ensure all necessary credentials are available and - documented. -- [ ] Sample Input Data: Ensure sample input data is provided and linked. -- [ ] PII: Verify if any Personally Identifiable Information (PII) is involved - and ensure proper handling. -- [ ] Collections: Confirm if collections are needed and pre-configure with - sample data if required. -- [ ] Mapping Spec: Ensure mapping specifications are complete and linked. -- [ ] API Docs: Ensure all relevant API documentation is linked. -- [ ] Workflow Diagrams: Ensure workflow diagrams are complete and linked. -- [ ] VPN Access: Ensure VPN Access is provided if required to run the workflow -- [ ] Toggl: Ensure the Toggl project name is provided. - ## QA Acceptance Criteria Before marking this issue as ready for review, complete the following checklist: @@ -124,3 +106,21 @@ Before marking this issue as ready for review, complete the following checklist: - [ ] Documented test data used (with IDs for reuse) - [ ] Documented any known issues or limitations - [ ] Documented assumptions made during implementation + +## Pre-Development Checklist + +Before handling this issue to a developer, ensure the following items are +checked: + +- [ ] Credentials: Ensure all necessary credentials are available and + documented. +- [ ] Sample Input Data: Ensure sample input data is provided and linked. +- [ ] PII: Verify if any Personally Identifiable Information (PII) is involved + and ensure proper handling. +- [ ] Collections: Confirm if collections are needed and pre-configure with + sample data if required. +- [ ] Mapping Spec: Ensure mapping specifications are complete and linked. +- [ ] API Docs: Ensure all relevant API documentation is linked. +- [ ] Workflow Diagrams: Ensure workflow diagrams are complete and linked. +- [ ] VPN Access: Ensure VPN Access is provided if required to run the workflow +- [ ] Toggl: Ensure the Toggl project name is provided. From 2bc4e87642bfb15ccf3956096e93299708e6d6cb Mon Sep 17 00:00:00 2001 From: Aisha Hassen <167166847+AishaHassen@users.noreply.github.com> Date: Tue, 3 Feb 2026 12:15:23 +0300 Subject: [PATCH 4/7] Update bug_report.md --- .github/ISSUE_TEMPLATE/bug_report.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index b659333..ddb30f2 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -96,3 +96,4 @@ checked: - [ ] Workflow Diagrams: Ensure workflow diagrams are complete and linked. - [ ] VPN Access: Ensure VPN Access is provided if required to run the workflow - [ ] Toggl: Ensure the Toggl project name is provided. +- [ ] Test Suite: A suite of test that the developer needs to run before handing the issue over to QA From 67cee2436d976b491e9cbc697ee6ec97588e4bcf Mon Sep 17 00:00:00 2001 From: Aisha Hassen <167166847+AishaHassen@users.noreply.github.com> Date: Tue, 3 Feb 2026 12:15:49 +0300 Subject: [PATCH 5/7] Add test suite checklist item to feature request template Added a checklist item for the test suite requirement before QA handover. --- .github/ISSUE_TEMPLATE/feature-request.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md index 6ed7035..279b7e5 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -124,3 +124,4 @@ checked: - [ ] Workflow Diagrams: Ensure workflow diagrams are complete and linked. - [ ] VPN Access: Ensure VPN Access is provided if required to run the workflow - [ ] Toggl: Ensure the Toggl project name is provided. +- [ ] Test Suite: A suite of test that the developer needs to run before handing the issue over to QA From ed349cd95e7a43758a7d7575a310d31dd44cbe7d Mon Sep 17 00:00:00 2001 From: Aisha Hassen <167166847+AishaHassen@users.noreply.github.com> Date: Tue, 3 Feb 2026 12:16:47 +0300 Subject: [PATCH 6/7] Update feature request template with test suite link Added a link to the test suite template in the feature request checklist. --- .github/ISSUE_TEMPLATE/feature-request.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md index 279b7e5..c392ad2 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -124,4 +124,4 @@ checked: - [ ] Workflow Diagrams: Ensure workflow diagrams are complete and linked. - [ ] VPN Access: Ensure VPN Access is provided if required to run the workflow - [ ] Toggl: Ensure the Toggl project name is provided. -- [ ] Test Suite: A suite of test that the developer needs to run before handing the issue over to QA +- [ ] Test Suite: A suite of test that the developer needs to run before handing the issue over to QA. ([Link to template](https://docs.google.com/spreadsheets/d/1GOs906ev239R1vgNRqcitH-LX8C5CTcw/edit?gid=931311464#gid=931311464)) From 3a31c8639ef3c0c137c7b3869a4da71f6b7fe008 Mon Sep 17 00:00:00 2001 From: Aisha Hassen <167166847+AishaHassen@users.noreply.github.com> Date: Tue, 3 Feb 2026 12:17:29 +0300 Subject: [PATCH 7/7] Update bug report template with test suite link Added a link to the test suite template in the bug report. --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index ddb30f2..1f4cb75 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -96,4 +96,4 @@ checked: - [ ] Workflow Diagrams: Ensure workflow diagrams are complete and linked. - [ ] VPN Access: Ensure VPN Access is provided if required to run the workflow - [ ] Toggl: Ensure the Toggl project name is provided. -- [ ] Test Suite: A suite of test that the developer needs to run before handing the issue over to QA +- [ ] Test Suite: A suite of test that the developer needs to run before handing the issue over to QA. ([Link to template](https://docs.google.com/spreadsheets/d/1GOs906ev239R1vgNRqcitH-LX8C5CTcw/edit?gid=931311464#gid=931311464))