From 71421ffedf7f63cf1eaad7b63b15db814fd29530 Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Fri, 5 Sep 2025 14:48:13 -0600 Subject: [PATCH 1/9] initial commit --- src/enhancementModels/Make/files | 1 + .../thompsonTsouris/thompsonTsouris.C | 223 ++++++++++++++++++ .../thompsonTsouris/thompsonTsouris.H | 122 ++++++++++ 3 files changed, 346 insertions(+) create mode 100644 src/enhancementModels/thompsonTsouris/thompsonTsouris.C create mode 100644 src/enhancementModels/thompsonTsouris/thompsonTsouris.H diff --git a/src/enhancementModels/Make/files b/src/enhancementModels/Make/files index 5a946c1..1c1a9f9 100644 --- a/src/enhancementModels/Make/files +++ b/src/enhancementModels/Make/files @@ -5,5 +5,6 @@ noEnhancement/noEnhancement.C lowHa/lowHa.C surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C filmPseudoFirstOrder/filmPseudoFirstOrder.C +thompsonTsouris/thompsonTsouris.C LIB = $(FOAM_USER_LIBBIN)/libenhancementModels diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C new file mode 100644 index 0000000..7233d25 --- /dev/null +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C @@ -0,0 +1,223 @@ +/*---------------------------------------------------------------------------*\ + ========= | + \\ / F ield | OpenFOAM: The Open Source CFD Toolbox + \\ / O peration | Website: https://openfoam.org + \\ / A nd | Copyright (C) 2011-2022 OpenFOAM Foundation + \\/ M anipulation | +------------------------------------------------------------------------------- + Copyright (C) 2023 Oak Ridge National Laboratory +------------------------------------------------------------------------------- +License + This file is part of OpenFOAM. + + OpenFOAM is free software: you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + OpenFOAM is distributed in the hope that it will be useful, but WITHOUT + ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + for more details. + + You should have received a copy of the GNU General Public License + along with OpenFOAM. If not, see . + +\*---------------------------------------------------------------------------*/ + +#include "thompsonTsouris.H" +#include "addToRunTimeSelectionTable.H" +#include "volFields.H" +#include + +// * * * * * * * * * * * * * * Static Data Members * * * * * * * * * * * * * // + +namespace Foam +{ +namespace enhancementModels +{ + defineTypeNameAndDebug(thompsonTsouris, 0); + addToRunTimeSelectionTable(enhancementModel, thompsonTsouris, dictionary); + + Foam::volScalarField& thompsonTsouris::Einf() + { + dimensionedScalar eps(dimMoles/dimVolume, 1.0e-16); + dimensionedScalar eps2(dimVolume/dimMoles, 1.0e-16); + + const volScalarField& rho = filmMesh_.lookupObject("rho"); + const volScalarField& CO2 = filmMesh_.lookupObject("CO2"); + const dimensionedScalar Wco2(dimMass/dimMoles, 44.0); + const volScalarField Cco2 = (rho * CO2 / Wco2) + eps; + + const volScalarField& rhobulk = bulkMesh_.lookupObject("rho"); + const volScalarField& CO2bulk = bulkMesh_.lookupObject("CO2"); + const volScalarField Cco2b = (rhobulk * CO2bulk / Wco2) + eps; + + if (filmMesh_.foundObject("MEA")) + { + const volScalarField& MEA = filmMesh_.lookupObject("MEA"); + const volScalarField& MEAp = filmMesh_.lookupObject("MEA+"); + const volScalarField& MEACOO = filmMesh_.lookupObject("MEACOO-"); + + const dimensionedScalar Wmea(dimMass/dimMoles, 61.0); + const dimensionedScalar Wmeap(dimMass/dimMoles, 62.0); + const dimensionedScalar Wmeacoo(dimMass/dimMoles, 104.0); + + const volScalarField C1 = rho * MEA / Wmea; + const volScalarField C2 = rho * MEAp / Wmeap; + const volScalarField C3 = rho * MEACOO / Wmeacoo; + + const volScalarField Keq = (C2 * C3 / (Cco2 * Foam::pow(C1, 2.0))) + eps2; + + dimensionedScalar Dmea(dimArea/dimTime, 1.61e-9); + dimensionedScalar Dmeacoo(dimArea/dimTime, 1.5e-9); + + volScalarField num = Foam::sqrt(Keq) * C1 * (Dmeacoo / D_); + volScalarField denom = (1.0 + (2.0 * Dmeacoo / Dmea)) * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2) + Foam::sqrt(Cco2)); + + Einf_ = 1.0 + (num / denom); + } + + else if (filmMesh_.foundObject("KSAR")) + { + const volScalarField& KSAR = filmMesh_.lookupObject("KSAR"); + const volScalarField& KSARp = filmMesh_.lookupObject("KSAR+"); + const volScalarField& KSARCOO = filmMesh_.lookupObject("KSARCOO-"); + + const dimensionedScalar Wksar(dimMass/dimMoles, 127.0); + const dimensionedScalar Wksarp(dimMass/dimMoles, 128.0); + const dimensionedScalar Wksarcoo(dimMass/dimMoles, 171.0); + + const volScalarField C1 = rho * KSAR / Wksar; + const volScalarField C2 = rho * KSARp / Wksarp; + const volScalarField C3 = rho * KSARCOO / Wksarcoo; + + const volScalarField Keq = C2 * C3/ (Cco2 * Foam::pow(C1, 2.0)) + eps2; + + dimensionedScalar Dksar(dimArea/dimTime, 1.0e-9); + dimensionedScalar Dksarcoo(dimArea/dimTime, 1.0e-9); + + volScalarField num = Foam::sqrt(Keq) * C1 * (Dksarcoo / D_); + volScalarField denom = (1.0 + (2.0 * Dksarcoo / Dksar)) * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2) + Foam::sqrt(Cco2)); + + Einf_ = 1.0 + (num / denom); + } + + else + { + //- Throw fatal error for unknown chemistry + FatalErrorInFunction + << "Neither MEA nor KSAR found in mixture." << nl + << "Please add known solvent for enhancement model." << endl + << exit(FatalError); + } + + return Einf_; + } +} +} + +// * * * * * * * * * * * * * * * * Constructors * * * * * * * * * * * * * * // + +Foam::enhancementModels::thompsonTsouris::thompsonTsouris +( + const dictionary& dict, + const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, + const label& filmSpecieID +) +: + enhancementModel + ( + typeName, + dict, + film, + fluid, + filmSpecieID + ), + + D1_(dimArea/dimTime/dimTemperature, massTransferModelCoeffs_.lookup("Dl1")), + D2_(dimArea/dimTime, massTransferModelCoeffs_.lookup("Dl2")), + + D_ + ( + IOobject + ( + "D", + filmMesh_.time().name(), + filmMesh_, + IOobject::READ_IF_PRESENT, + IOobject::AUTO_WRITE + ), + filmMesh_, + dimensionedScalar(dimArea/dimTime, 0.0) + ), + + tStart_(massTransferModelCoeffs_.lookupOrDefault("tStart", 0.0)), + + Einf_ + ( + IOobject + ( + "Einf", + filmMesh_.time().name(), + filmMesh_, + IOobject::READ_IF_PRESENT, + IOobject::AUTO_WRITE + ), + filmMesh_, + dimensionedScalar(dimless, 0.01) + ) + +{ +} + + +// * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * * // + +void Foam::enhancementModels::thompsonTsouris::update() +{ + + //- Look up film-side mass transfer rate coefficient field + const volScalarField& k_l = filmMesh_.lookupObject("k"); + const volScalarField& Tf = filmMesh_.lookupObject("T"); + + const volScalarField klLim + = max(k_l, dimensionedScalar(dimVelocity, 1e-8)); + + dimensionedScalar D1(dimArea/dimTime/dimTemperature, D1_.value()); + dimensionedScalar D2(dimArea/dimTime, D2_.value()); + // const volScalarField D = (D1 * Tf) + D2; + D_ = (D1 * Tf) + D2; + + //- Set E + if (filmMesh_.time().value() >= tStart_) + { + Einf(); + + const volScalarField Ha = Foam::sqrt(D_ * enhancementModel::kApp()) / klLim; + + volScalarField denom = (1.0 / Foam::pow(Ha - 1.0, 1.35)) + + (1.0 / Foam::pow(Einf_ - 1.0, 1.35)); + + E_ = 1.0 + (1.0 / Foam::pow(denom, 0.74)); + +// E_ = Einf_; +// Info << "E_: " << E_ << " at time: " << filmMesh_.time().value() << endl; + } +} + +bool Foam::enhancementModels::thompsonTsouris::read() +{ + if (enhancementModel::read()) + { + return true; + } + + else + { + return false; + } +} + +// ************************************************************************* // diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.H b/src/enhancementModels/thompsonTsouris/thompsonTsouris.H new file mode 100644 index 0000000..da43532 --- /dev/null +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.H @@ -0,0 +1,122 @@ +/*---------------------------------------------------------------------------*\ + ========= | + \\ / F ield | OpenFOAM: The Open Source CFD Toolbox + \\ / O peration | Website: https://openfoam.org + \\ / A nd | Copyright (C) 2011-2022 OpenFOAM Foundation + \\/ M anipulation | +------------------------------------------------------------------------------- + Copyright (C) 2023 Oak Ridge National Laboratory +------------------------------------------------------------------------------- +License + This file is part of OpenFOAM. + + OpenFOAM is free software: you can redistribute it and/or modify it + under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + OpenFOAM is distributed in the hope that it will be useful, but WITHOUT + ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + for more details. + + You should have received a copy of the GNU General Public License + along with OpenFOAM. If not, see . + +Class + Foam::interphaseMassTransferModels::thompsonTsouris + +Description + Enhancement factor from: + + Thompson, J. A., & Tsouris, C. (2021). Rate-based absorption modeling for + postcombustion CO2 capture with additively manufactured structured packing. + Industrial & Engineering Chemistry Research, 60(41), 14845-14855. + +SourceFiles + thompsonTsouris.C + +\*---------------------------------------------------------------------------*/ + +#ifndef thompsonTsouris_H +#define thompsonTsouris_H + +#include "enhancementModel.H" + +// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // + +namespace Foam +{ +namespace enhancementModels +{ + +/*---------------------------------------------------------------------------*\ + Class thompsonTsouris +\*---------------------------------------------------------------------------*/ + +class thompsonTsouris +: + public enhancementModel +{ + // Private Data + + //- 1st coefficient of Diffusivity of specie in liquid + const dimensionedScalar D1_; + + //- 2nd coefficient of Diffusivity of specie in liquid + const dimensionedScalar D2_; + + volScalarField D_; + + //- Time to turn enhancement on + const scalar tStart_; + + //- Instantaneous enhancement factor + volScalarField Einf_; + +public: + + //- Runtime type information + TypeName("thompsonTsouris"); + + + // Constructors + + //- Construct from components + thompsonTsouris + ( + const dictionary& dict, + const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, + const label& filmSpecieID + ); + + + //- Destructor + virtual ~thompsonTsouris() + {} + + + // Member Functions + + //- Update mass transfer field + virtual void update(); + + //- Calculate and return instantaneous enhancement factor + volScalarField& Einf(); + + //- Read the dictionary + virtual bool read(); +}; + + +// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // + +} // End namespace interphaseMassTransferModels +} // End namespace Foam + +// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // + +#endif + +// ************************************************************************* // From 04774fedde14f77a4706484a3c1e176394f59d68 Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Fri, 5 Sep 2025 15:22:00 -0600 Subject: [PATCH 2/9] edits --- src/enhancementModels/Make/options | 4 ++++ src/enhancementModels/enhancementModel/enhancementModel.C | 5 ++++- src/enhancementModels/enhancementModel/enhancementModel.H | 6 +++++- .../enhancementModel/enhancementModelNew.C | 3 ++- src/enhancementModels/lowHa/lowHa.C | 2 ++ src/enhancementModels/lowHa/lowHa.H | 1 + src/enhancementModels/noEnhancement/noEnhancement.C | 2 ++ src/enhancementModels/noEnhancement/noEnhancement.H | 1 + src/interphaseMassTransferModels/physical/physical.C | 1 + 9 files changed, 22 insertions(+), 3 deletions(-) diff --git a/src/enhancementModels/Make/options b/src/enhancementModels/Make/options index c8c1688..2ff2301 100644 --- a/src/enhancementModels/Make/options +++ b/src/enhancementModels/Make/options @@ -3,6 +3,9 @@ EXE_INC = \ -I../../applications/modules/multicomponentFilm/filmMulticomponentThermophysicalTransportModels/lnInclude \ -I$(FOAM_MODULES)/isothermalFilm/lnInclude \ -I$(FOAM_MODULES)/isothermalFilm/filmCompressibleMomentumTransportModels/lnInclude \ + -I$(FOAM_MODULES)/multicomponentFluid/lnInclude \ + -I$(FOAM_MODULES)/isothermalFluid/lnInclude \ + -I$(FOAM_MODULES)/fluidSolver/lnInclude \ -I$(LIB_SRC)/thermophysicalModels/basic/lnInclude \ -I$(LIB_SRC)/physicalProperties/lnInclude \ -I$(LIB_SRC)/MomentumTransportModels/momentumTransportModels/lnInclude \ @@ -24,5 +27,6 @@ LIB_LIBS = \ -lmulticomponentFilm \ -lfluidThermophysicalModels \ -lfilmCompressibleMomentumTransportModels \ + -lmulticomponentFluid \ -lmeshTools \ -lfiniteVolume diff --git a/src/enhancementModels/enhancementModel/enhancementModel.C b/src/enhancementModels/enhancementModel/enhancementModel.C index c2290eb..e4bdbb5 100644 --- a/src/enhancementModels/enhancementModel/enhancementModel.C +++ b/src/enhancementModels/enhancementModel/enhancementModel.C @@ -42,6 +42,7 @@ Foam::enhancementModel::enhancementModel const word& type, const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ) : @@ -74,7 +75,9 @@ Foam::enhancementModel::enhancementModel ), filmMesh_, dimensionedScalar(dimless / dimTime, 1.0) - ) + ), + fluid_(fluid), + bulkMesh_(fluid_.p.mesh()) { } diff --git a/src/enhancementModels/enhancementModel/enhancementModel.H b/src/enhancementModels/enhancementModel/enhancementModel.H index 4bcfa4f..3541d6b 100644 --- a/src/enhancementModels/enhancementModel/enhancementModel.H +++ b/src/enhancementModels/enhancementModel/enhancementModel.H @@ -43,6 +43,7 @@ SourceFiles #include "dictionary.H" #include "volFields.H" #include "multicomponentFilm.H" +#include "multicomponentFluid.H" #include "fvc.H" // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // @@ -93,9 +94,10 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ), - (dict, film, filmSpecieID) + (dict, film, fluid, filmSpecieID) ); @@ -107,6 +109,7 @@ public: const word& type, const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); @@ -120,6 +123,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); diff --git a/src/enhancementModels/enhancementModel/enhancementModelNew.C b/src/enhancementModels/enhancementModel/enhancementModelNew.C index 152b75f..76ff145 100644 --- a/src/enhancementModels/enhancementModel/enhancementModelNew.C +++ b/src/enhancementModels/enhancementModel/enhancementModelNew.C @@ -33,6 +33,7 @@ Foam::autoPtr Foam::enhancementModel::New ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ) { @@ -56,7 +57,7 @@ Foam::autoPtr Foam::enhancementModel::New << exit(FatalError); } - return autoPtr(cstrIter()(dict, film, filmSpecieID)); + return autoPtr(cstrIter()(dict, film, fluid, filmSpecieID)); } diff --git a/src/enhancementModels/lowHa/lowHa.C b/src/enhancementModels/lowHa/lowHa.C index 648c2bd..fba89af 100644 --- a/src/enhancementModels/lowHa/lowHa.C +++ b/src/enhancementModels/lowHa/lowHa.C @@ -45,6 +45,7 @@ Foam::enhancementModels::lowHa::lowHa ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ) : @@ -53,6 +54,7 @@ Foam::enhancementModels::lowHa::lowHa typeName, dict, film, + fluid, filmSpecieID ), diff --git a/src/enhancementModels/lowHa/lowHa.H b/src/enhancementModels/lowHa/lowHa.H index d268b1e..7763467 100644 --- a/src/enhancementModels/lowHa/lowHa.H +++ b/src/enhancementModels/lowHa/lowHa.H @@ -78,6 +78,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); diff --git a/src/enhancementModels/noEnhancement/noEnhancement.C b/src/enhancementModels/noEnhancement/noEnhancement.C index bb72304..09748b1 100644 --- a/src/enhancementModels/noEnhancement/noEnhancement.C +++ b/src/enhancementModels/noEnhancement/noEnhancement.C @@ -45,6 +45,7 @@ Foam::enhancementModels::noEnhancement::noEnhancement ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ) : @@ -53,6 +54,7 @@ Foam::enhancementModels::noEnhancement::noEnhancement typeName, dict, film, + fluid, filmSpecieID ) { diff --git a/src/enhancementModels/noEnhancement/noEnhancement.H b/src/enhancementModels/noEnhancement/noEnhancement.H index f5b7d09..3bcb631 100644 --- a/src/enhancementModels/noEnhancement/noEnhancement.H +++ b/src/enhancementModels/noEnhancement/noEnhancement.H @@ -68,6 +68,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); diff --git a/src/interphaseMassTransferModels/physical/physical.C b/src/interphaseMassTransferModels/physical/physical.C index cbfb458..a221329 100644 --- a/src/interphaseMassTransferModels/physical/physical.C +++ b/src/interphaseMassTransferModels/physical/physical.C @@ -102,6 +102,7 @@ Foam::interphaseMassTransferModels::physical::physical ( massTransferModelCoeffs_, film_, + fluid_, filmSpecieID_ ); } From 6c46b8eea352a62268e8caed9ea2b22a3f60da8e Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Fri, 5 Sep 2025 15:28:19 -0600 Subject: [PATCH 3/9] edits 2 --- .../surfaceRenewalPseudoFirstOrder.C | 2 ++ .../surfaceRenewalPseudoFirstOrder.H | 1 + 2 files changed, 3 insertions(+) diff --git a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C index d5fb7bf..bfd866b 100644 --- a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C +++ b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C @@ -45,6 +45,7 @@ Foam::enhancementModels::surfaceRenewalPseudoFirstOrder::surfaceRenewalPseudoFir ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ) : @@ -53,6 +54,7 @@ Foam::enhancementModels::surfaceRenewalPseudoFirstOrder::surfaceRenewalPseudoFir typeName, dict, film, + fluid, filmSpecieID ), diff --git a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H index 4ac354d..dfd8846 100644 --- a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H +++ b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H @@ -88,6 +88,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); From 353e91735a826aa9e08e11cbe4dbc2c375ffad34 Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Fri, 5 Sep 2025 15:37:11 -0600 Subject: [PATCH 4/9] edits 3 --- src/enhancementModels/enhancementModel/enhancementModel.H | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/enhancementModels/enhancementModel/enhancementModel.H b/src/enhancementModels/enhancementModel/enhancementModel.H index 3541d6b..4303811 100644 --- a/src/enhancementModels/enhancementModel/enhancementModel.H +++ b/src/enhancementModels/enhancementModel/enhancementModel.H @@ -80,6 +80,12 @@ protected: //- Apparent reaction rate volScalarField kApp_; + //- Pointer to bulk phase instance + const solvers::multicomponentFluid& fluid_; + + //- Pointer to bulk mesh instance + const fvMesh& bulkMesh_; + public: //- Runtime type information From 85e99bf12980a0ff88056b11a113ff1e6d08d87b Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Mon, 8 Sep 2025 11:16:19 -0600 Subject: [PATCH 5/9] identation --- src/enhancementModels/enhancementModel/enhancementModel.H | 6 +++--- src/enhancementModels/lowHa/lowHa.C | 2 +- src/enhancementModels/lowHa/lowHa.H | 2 +- src/enhancementModels/noEnhancement/noEnhancement.C | 2 +- src/enhancementModels/noEnhancement/noEnhancement.H | 2 +- .../surfaceRenewalPseudoFirstOrder.C | 2 +- .../surfaceRenewalPseudoFirstOrder.H | 2 +- src/enhancementModels/thompsonTsouris/thompsonTsouris.C | 2 +- src/enhancementModels/thompsonTsouris/thompsonTsouris.H | 6 +++--- src/interphaseMassTransferModels/physical/physical.C | 2 +- 10 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/enhancementModels/enhancementModel/enhancementModel.H b/src/enhancementModels/enhancementModel/enhancementModel.H index 4303811..a395369 100644 --- a/src/enhancementModels/enhancementModel/enhancementModel.H +++ b/src/enhancementModels/enhancementModel/enhancementModel.H @@ -100,7 +100,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, - const solvers::multicomponentFluid& fluid, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ), (dict, film, fluid, filmSpecieID) @@ -115,7 +115,7 @@ public: const word& type, const dictionary& dict, const solvers::multicomponentFilm& film, - const solvers::multicomponentFluid& fluid, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); @@ -129,7 +129,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, - const solvers::multicomponentFluid& fluid, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); diff --git a/src/enhancementModels/lowHa/lowHa.C b/src/enhancementModels/lowHa/lowHa.C index fba89af..39c3fb5 100644 --- a/src/enhancementModels/lowHa/lowHa.C +++ b/src/enhancementModels/lowHa/lowHa.C @@ -54,7 +54,7 @@ Foam::enhancementModels::lowHa::lowHa typeName, dict, film, - fluid, + fluid, filmSpecieID ), diff --git a/src/enhancementModels/lowHa/lowHa.H b/src/enhancementModels/lowHa/lowHa.H index 7763467..928ddd9 100644 --- a/src/enhancementModels/lowHa/lowHa.H +++ b/src/enhancementModels/lowHa/lowHa.H @@ -78,7 +78,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, - const solvers::multicomponentFluid& fluid, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); diff --git a/src/enhancementModels/noEnhancement/noEnhancement.C b/src/enhancementModels/noEnhancement/noEnhancement.C index 09748b1..486ff61 100644 --- a/src/enhancementModels/noEnhancement/noEnhancement.C +++ b/src/enhancementModels/noEnhancement/noEnhancement.C @@ -54,7 +54,7 @@ Foam::enhancementModels::noEnhancement::noEnhancement typeName, dict, film, - fluid, + fluid, filmSpecieID ) { diff --git a/src/enhancementModels/noEnhancement/noEnhancement.H b/src/enhancementModels/noEnhancement/noEnhancement.H index 3bcb631..6d1886a 100644 --- a/src/enhancementModels/noEnhancement/noEnhancement.H +++ b/src/enhancementModels/noEnhancement/noEnhancement.H @@ -68,7 +68,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, - const solvers::multicomponentFluid& fluid, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); diff --git a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C index bfd866b..9a9d075 100644 --- a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C +++ b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C @@ -54,7 +54,7 @@ Foam::enhancementModels::surfaceRenewalPseudoFirstOrder::surfaceRenewalPseudoFir typeName, dict, film, - fluid, + fluid, filmSpecieID ), diff --git a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H index dfd8846..12322d3 100644 --- a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H +++ b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H @@ -88,7 +88,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, - const solvers::multicomponentFluid& fluid, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C index 7233d25..84de808 100644 --- a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C @@ -132,7 +132,7 @@ Foam::enhancementModels::thompsonTsouris::thompsonTsouris typeName, dict, film, - fluid, + fluid, filmSpecieID ), diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.H b/src/enhancementModels/thompsonTsouris/thompsonTsouris.H index da43532..8d0e017 100644 --- a/src/enhancementModels/thompsonTsouris/thompsonTsouris.H +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.H @@ -87,7 +87,7 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, - const solvers::multicomponentFluid& fluid, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID ); @@ -102,8 +102,8 @@ public: //- Update mass transfer field virtual void update(); - //- Calculate and return instantaneous enhancement factor - volScalarField& Einf(); + //- Calculate and return instantaneous enhancement factor + volScalarField& Einf(); //- Read the dictionary virtual bool read(); diff --git a/src/interphaseMassTransferModels/physical/physical.C b/src/interphaseMassTransferModels/physical/physical.C index a221329..b8693b2 100644 --- a/src/interphaseMassTransferModels/physical/physical.C +++ b/src/interphaseMassTransferModels/physical/physical.C @@ -102,7 +102,7 @@ Foam::interphaseMassTransferModels::physical::physical ( massTransferModelCoeffs_, film_, - fluid_, + fluid_, filmSpecieID_ ); } From 789ea45312137fd4506687e037468f3af2bd880c Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Wed, 8 Oct 2025 14:53:21 -0600 Subject: [PATCH 6/9] edit 4 --- src/enhancementModels/thompsonTsouris/thompsonTsouris.C | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C index 84de808..38cf111 100644 --- a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C @@ -73,7 +73,7 @@ namespace enhancementModels dimensionedScalar Dmeacoo(dimArea/dimTime, 1.5e-9); volScalarField num = Foam::sqrt(Keq) * C1 * (Dmeacoo / D_); - volScalarField denom = (1.0 + (2.0 * Dmeacoo / Dmea)) * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2) + Foam::sqrt(Cco2)); + volScalarField denom = (1.0 + (2.0 * Dmeacoo / Dmea)) * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2b) + Foam::sqrt(Cco2)); Einf_ = 1.0 + (num / denom); } @@ -98,7 +98,7 @@ namespace enhancementModels dimensionedScalar Dksarcoo(dimArea/dimTime, 1.0e-9); volScalarField num = Foam::sqrt(Keq) * C1 * (Dksarcoo / D_); - volScalarField denom = (1.0 + (2.0 * Dksarcoo / Dksar)) * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2) + Foam::sqrt(Cco2)); + volScalarField denom = (1.0 + (2.0 * Dksarcoo / Dksar)) * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2b) + Foam::sqrt(Cco2)); Einf_ = 1.0 + (num / denom); } From 28849a4045730f86aa8b811dd1b3d194ff6c4d7d Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Fri, 10 Oct 2025 11:13:53 -0600 Subject: [PATCH 7/9] interface value computed --- .../enhancementModel/enhancementModel.C | 6 ++-- .../enhancementModel/enhancementModel.H | 14 +++++--- .../enhancementModel/enhancementModelNew.C | 5 +-- src/enhancementModels/lowHa/lowHa.C | 6 ++-- src/enhancementModels/lowHa/lowHa.H | 3 +- .../noEnhancement/noEnhancement.C | 6 ++-- .../noEnhancement/noEnhancement.H | 3 +- .../surfaceRenewalPseudoFirstOrder.C | 6 ++-- .../surfaceRenewalPseudoFirstOrder.H | 3 +- .../thompsonTsouris/thompsonTsouris.C | 35 +++++++++++++------ .../thompsonTsouris/thompsonTsouris.H | 6 +++- .../physical/physical.C | 3 +- 12 files changed, 67 insertions(+), 29 deletions(-) diff --git a/src/enhancementModels/enhancementModel/enhancementModel.C b/src/enhancementModels/enhancementModel/enhancementModel.C index e4bdbb5..6f53e87 100644 --- a/src/enhancementModels/enhancementModel/enhancementModel.C +++ b/src/enhancementModels/enhancementModel/enhancementModel.C @@ -43,7 +43,8 @@ Foam::enhancementModel::enhancementModel const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ) : massTransferModelCoeffs_(dict.optionalSubDict(type + "Coeffs")), @@ -77,7 +78,8 @@ Foam::enhancementModel::enhancementModel dimensionedScalar(dimless / dimTime, 1.0) ), fluid_(fluid), - bulkMesh_(fluid_.p.mesh()) + bulkMesh_(fluid_.p.mesh()), + bulkPatchID_(bulkPatchID) { } diff --git a/src/enhancementModels/enhancementModel/enhancementModel.H b/src/enhancementModels/enhancementModel/enhancementModel.H index a395369..d361370 100644 --- a/src/enhancementModels/enhancementModel/enhancementModel.H +++ b/src/enhancementModels/enhancementModel/enhancementModel.H @@ -86,6 +86,9 @@ protected: //- Pointer to bulk mesh instance const fvMesh& bulkMesh_; + //- Index of mass transfer patch in bulk mesh + const label bulkPatchID_; + public: //- Runtime type information @@ -101,9 +104,10 @@ public: const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ), - (dict, film, fluid, filmSpecieID) + (dict, film, fluid, filmSpecieID, bulkPatchID) ); @@ -116,7 +120,8 @@ public: const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ); //- Disallow default bitwise copy construction @@ -130,7 +135,8 @@ public: const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ); //- Destructor diff --git a/src/enhancementModels/enhancementModel/enhancementModelNew.C b/src/enhancementModels/enhancementModel/enhancementModelNew.C index 76ff145..c239b41 100644 --- a/src/enhancementModels/enhancementModel/enhancementModelNew.C +++ b/src/enhancementModels/enhancementModel/enhancementModelNew.C @@ -34,7 +34,8 @@ Foam::autoPtr Foam::enhancementModel::New const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ) { //- Initialize modelType to a non-model word @@ -57,7 +58,7 @@ Foam::autoPtr Foam::enhancementModel::New << exit(FatalError); } - return autoPtr(cstrIter()(dict, film, fluid, filmSpecieID)); + return autoPtr(cstrIter()(dict, film, fluid, filmSpecieID, bulkPatchID)); } diff --git a/src/enhancementModels/lowHa/lowHa.C b/src/enhancementModels/lowHa/lowHa.C index 39c3fb5..96978c3 100644 --- a/src/enhancementModels/lowHa/lowHa.C +++ b/src/enhancementModels/lowHa/lowHa.C @@ -46,7 +46,8 @@ Foam::enhancementModels::lowHa::lowHa const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ) : enhancementModel @@ -55,7 +56,8 @@ Foam::enhancementModels::lowHa::lowHa dict, film, fluid, - filmSpecieID + filmSpecieID, + bulkPatchID ), D1_(dimArea/dimTime/dimTemperature, massTransferModelCoeffs_.lookup("Dl1")), diff --git a/src/enhancementModels/lowHa/lowHa.H b/src/enhancementModels/lowHa/lowHa.H index 928ddd9..c78093c 100644 --- a/src/enhancementModels/lowHa/lowHa.H +++ b/src/enhancementModels/lowHa/lowHa.H @@ -79,7 +79,8 @@ public: const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ); diff --git a/src/enhancementModels/noEnhancement/noEnhancement.C b/src/enhancementModels/noEnhancement/noEnhancement.C index 486ff61..6c3db9b 100644 --- a/src/enhancementModels/noEnhancement/noEnhancement.C +++ b/src/enhancementModels/noEnhancement/noEnhancement.C @@ -46,7 +46,8 @@ Foam::enhancementModels::noEnhancement::noEnhancement const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ) : enhancementModel @@ -55,7 +56,8 @@ Foam::enhancementModels::noEnhancement::noEnhancement dict, film, fluid, - filmSpecieID + filmSpecieID, + bulkPatchID ) { } diff --git a/src/enhancementModels/noEnhancement/noEnhancement.H b/src/enhancementModels/noEnhancement/noEnhancement.H index 6d1886a..8b28eb6 100644 --- a/src/enhancementModels/noEnhancement/noEnhancement.H +++ b/src/enhancementModels/noEnhancement/noEnhancement.H @@ -69,7 +69,8 @@ public: const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ); diff --git a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C index 9a9d075..848a38b 100644 --- a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C +++ b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C @@ -46,7 +46,8 @@ Foam::enhancementModels::surfaceRenewalPseudoFirstOrder::surfaceRenewalPseudoFir const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ) : enhancementModel @@ -55,7 +56,8 @@ Foam::enhancementModels::surfaceRenewalPseudoFirstOrder::surfaceRenewalPseudoFir dict, film, fluid, - filmSpecieID + filmSpecieID, + bulkPatchID ), D1_(dimArea/dimTime/dimTemperature, massTransferModelCoeffs_.lookup("Dl1")), diff --git a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H index 12322d3..65d8b3f 100644 --- a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H +++ b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H @@ -89,7 +89,8 @@ public: const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ); diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C index 38cf111..a09a2fe 100644 --- a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C @@ -29,6 +29,7 @@ License #include "addToRunTimeSelectionTable.H" #include "volFields.H" #include +#include "OFstream.H" // * * * * * * * * * * * * * * Static Data Members * * * * * * * * * * * * * // @@ -49,9 +50,22 @@ namespace enhancementModels const dimensionedScalar Wco2(dimMass/dimMoles, 44.0); const volScalarField Cco2 = (rho * CO2 / Wco2) + eps; - const volScalarField& rhobulk = bulkMesh_.lookupObject("rho"); - const volScalarField& CO2bulk = bulkMesh_.lookupObject("CO2"); - const volScalarField Cco2b = (rhobulk * CO2bulk / Wco2) + eps; + const fvPatchScalarField& rhobulkPatch = bulkMesh_.lookupObject("rho").boundaryField()[bulkPatchID_]; + const fvPatchScalarField& CO2bulkPatch = bulkMesh_.lookupObject("CO2").boundaryField()[bulkPatchID_]; + const scalarField Cco2bPatch = (rhobulkPatch * CO2bulkPatch / Wco2.value()) + eps.value(); + + volScalarField Cco2b + ( + IOobject + ( + "Cco2b", + filmMesh_.time().name(), + filmMesh_ + ), + filmMesh_, + dimensionedScalar(dimMoles/dimVolume, 0.0) + ); + Cco2b.boundaryFieldRef()[filmPatchID_] = Cco2bPatch; if (filmMesh_.foundObject("MEA")) { @@ -124,7 +138,8 @@ Foam::enhancementModels::thompsonTsouris::thompsonTsouris const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ) : enhancementModel @@ -133,7 +148,8 @@ Foam::enhancementModels::thompsonTsouris::thompsonTsouris dict, film, fluid, - filmSpecieID + filmSpecieID, + bulkPatchID ), D1_(dimArea/dimTime/dimTemperature, massTransferModelCoeffs_.lookup("Dl1")), @@ -167,7 +183,9 @@ Foam::enhancementModels::thompsonTsouris::thompsonTsouris ), filmMesh_, dimensionedScalar(dimless, 0.01) - ) + ), + + filmPatchID_(film_.surfacePatch().index()) { } @@ -187,7 +205,6 @@ void Foam::enhancementModels::thompsonTsouris::update() dimensionedScalar D1(dimArea/dimTime/dimTemperature, D1_.value()); dimensionedScalar D2(dimArea/dimTime, D2_.value()); - // const volScalarField D = (D1 * Tf) + D2; D_ = (D1 * Tf) + D2; //- Set E @@ -201,9 +218,7 @@ void Foam::enhancementModels::thompsonTsouris::update() + (1.0 / Foam::pow(Einf_ - 1.0, 1.35)); E_ = 1.0 + (1.0 / Foam::pow(denom, 0.74)); - -// E_ = Einf_; -// Info << "E_: " << E_ << " at time: " << filmMesh_.time().value() << endl; + } } diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.H b/src/enhancementModels/thompsonTsouris/thompsonTsouris.H index 8d0e017..e3ded50 100644 --- a/src/enhancementModels/thompsonTsouris/thompsonTsouris.H +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.H @@ -74,6 +74,9 @@ class thompsonTsouris //- Instantaneous enhancement factor volScalarField Einf_; + //- Index of mass transfer patch in film mesh + const label filmPatchID_; + public: //- Runtime type information @@ -88,7 +91,8 @@ public: const dictionary& dict, const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, - const label& filmSpecieID + const label& filmSpecieID, + const label& bulkPatchID ); diff --git a/src/interphaseMassTransferModels/physical/physical.C b/src/interphaseMassTransferModels/physical/physical.C index b8693b2..8db2cdd 100644 --- a/src/interphaseMassTransferModels/physical/physical.C +++ b/src/interphaseMassTransferModels/physical/physical.C @@ -103,7 +103,8 @@ Foam::interphaseMassTransferModels::physical::physical massTransferModelCoeffs_, film_, fluid_, - filmSpecieID_ + filmSpecieID_, + bulkPatchID_ ); } From b62739760bf730cfab1112b5b8ff47e9f068169b Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Thu, 30 Oct 2025 12:53:46 -0600 Subject: [PATCH 8/9] new edits --- .../enhancementModel/enhancementModel.H | 6 +++--- .../filmPseudoFirstOrder/filmPseudoFirstOrder.C | 8 ++++++-- .../filmPseudoFirstOrder/filmPseudoFirstOrder.H | 4 +++- src/enhancementModels/lowHa/lowHa.C | 2 +- src/enhancementModels/lowHa/lowHa.H | 2 +- src/enhancementModels/noEnhancement/noEnhancement.C | 2 +- src/enhancementModels/noEnhancement/noEnhancement.H | 2 +- .../surfaceRenewalPseudoFirstOrder.C | 2 +- .../surfaceRenewalPseudoFirstOrder.H | 2 +- .../thompsonTsouris/thompsonTsouris.C | 12 +++++++----- .../thompsonTsouris/thompsonTsouris.H | 11 ++++++----- src/interphaseMassTransferModels/physical/physical.C | 2 +- 12 files changed, 32 insertions(+), 23 deletions(-) diff --git a/src/enhancementModels/enhancementModel/enhancementModel.H b/src/enhancementModels/enhancementModel/enhancementModel.H index d361370..8acf030 100644 --- a/src/enhancementModels/enhancementModel/enhancementModel.H +++ b/src/enhancementModels/enhancementModel/enhancementModel.H @@ -105,7 +105,7 @@ public: const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, const label& filmSpecieID, - const label& bulkPatchID + const label& bulkPatchID ), (dict, film, fluid, filmSpecieID, bulkPatchID) ); @@ -121,7 +121,7 @@ public: const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, const label& filmSpecieID, - const label& bulkPatchID + const label& bulkPatchID ); //- Disallow default bitwise copy construction @@ -136,7 +136,7 @@ public: const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, const label& filmSpecieID, - const label& bulkPatchID + const label& bulkPatchID ); //- Destructor diff --git a/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.C b/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.C index 19df717..7ea367e 100644 --- a/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.C +++ b/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.C @@ -46,7 +46,9 @@ Foam::enhancementModels::filmPseudoFirstOrder::filmPseudoFirstOrder ( const dictionary& dict, const solvers::multicomponentFilm& film, - const label& filmSpecieID + const solvers::multicomponentFluid& fluid, + const label& filmSpecieID, + const label& bulkPatchID ) : enhancementModel @@ -54,7 +56,9 @@ Foam::enhancementModels::filmPseudoFirstOrder::filmPseudoFirstOrder typeName, dict, film, - filmSpecieID + fluid, + filmSpecieID, + bulkPatchID ), D1_(dimArea/dimTime/dimTemperature, diff --git a/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.H b/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.H index cd18ef0..b199e46 100644 --- a/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.H +++ b/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.H @@ -90,7 +90,9 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, - const label& filmSpecieID + const solvers::multicomponentFluid& fluid, + const label& filmSpecieID, + const label& bulkPatchID ); diff --git a/src/enhancementModels/lowHa/lowHa.C b/src/enhancementModels/lowHa/lowHa.C index 96978c3..ee382b5 100644 --- a/src/enhancementModels/lowHa/lowHa.C +++ b/src/enhancementModels/lowHa/lowHa.C @@ -57,7 +57,7 @@ Foam::enhancementModels::lowHa::lowHa film, fluid, filmSpecieID, - bulkPatchID + bulkPatchID ), D1_(dimArea/dimTime/dimTemperature, massTransferModelCoeffs_.lookup("Dl1")), diff --git a/src/enhancementModels/lowHa/lowHa.H b/src/enhancementModels/lowHa/lowHa.H index c78093c..3367732 100644 --- a/src/enhancementModels/lowHa/lowHa.H +++ b/src/enhancementModels/lowHa/lowHa.H @@ -80,7 +80,7 @@ public: const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, const label& filmSpecieID, - const label& bulkPatchID + const label& bulkPatchID ); diff --git a/src/enhancementModels/noEnhancement/noEnhancement.C b/src/enhancementModels/noEnhancement/noEnhancement.C index 6c3db9b..f101189 100644 --- a/src/enhancementModels/noEnhancement/noEnhancement.C +++ b/src/enhancementModels/noEnhancement/noEnhancement.C @@ -57,7 +57,7 @@ Foam::enhancementModels::noEnhancement::noEnhancement film, fluid, filmSpecieID, - bulkPatchID + bulkPatchID ) { } diff --git a/src/enhancementModels/noEnhancement/noEnhancement.H b/src/enhancementModels/noEnhancement/noEnhancement.H index 8b28eb6..a709c20 100644 --- a/src/enhancementModels/noEnhancement/noEnhancement.H +++ b/src/enhancementModels/noEnhancement/noEnhancement.H @@ -70,7 +70,7 @@ public: const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, const label& filmSpecieID, - const label& bulkPatchID + const label& bulkPatchID ); diff --git a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C index 848a38b..d4553da 100644 --- a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C +++ b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.C @@ -57,7 +57,7 @@ Foam::enhancementModels::surfaceRenewalPseudoFirstOrder::surfaceRenewalPseudoFir film, fluid, filmSpecieID, - bulkPatchID + bulkPatchID ), D1_(dimArea/dimTime/dimTemperature, massTransferModelCoeffs_.lookup("Dl1")), diff --git a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H index 65d8b3f..2d9df1c 100644 --- a/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H +++ b/src/enhancementModels/surfaceRenewalPseudoFirstOrder/surfaceRenewalPseudoFirstOrder.H @@ -90,7 +90,7 @@ public: const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, const label& filmSpecieID, - const label& bulkPatchID + const label& bulkPatchID ); diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C index a09a2fe..51537b7 100644 --- a/src/enhancementModels/thompsonTsouris/thompsonTsouris.C +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.C @@ -44,8 +44,8 @@ namespace enhancementModels { dimensionedScalar eps(dimMoles/dimVolume, 1.0e-16); dimensionedScalar eps2(dimVolume/dimMoles, 1.0e-16); - - const volScalarField& rho = filmMesh_.lookupObject("rho"); + + const volScalarField& rho = filmMesh_.lookupObject("rho"); const volScalarField& CO2 = filmMesh_.lookupObject("CO2"); const dimensionedScalar Wco2(dimMass/dimMoles, 44.0); const volScalarField Cco2 = (rho * CO2 / Wco2) + eps; @@ -87,7 +87,8 @@ namespace enhancementModels dimensionedScalar Dmeacoo(dimArea/dimTime, 1.5e-9); volScalarField num = Foam::sqrt(Keq) * C1 * (Dmeacoo / D_); - volScalarField denom = (1.0 + (2.0 * Dmeacoo / Dmea)) * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2b) + Foam::sqrt(Cco2)); + volScalarField denom = (1.0 + (2.0 * Dmeacoo / Dmea)) + * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2b) + Foam::sqrt(Cco2)); Einf_ = 1.0 + (num / denom); } @@ -112,7 +113,8 @@ namespace enhancementModels dimensionedScalar Dksarcoo(dimArea/dimTime, 1.0e-9); volScalarField num = Foam::sqrt(Keq) * C1 * (Dksarcoo / D_); - volScalarField denom = (1.0 + (2.0 * Dksarcoo / Dksar)) * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2b) + Foam::sqrt(Cco2)); + volScalarField denom = (1.0 + (2.0 * Dksarcoo / Dksar)) + * Foam::sqrt(Keq * Cco2) * (Foam::sqrt(Cco2b) + Foam::sqrt(Cco2)); Einf_ = 1.0 + (num / denom); } @@ -149,7 +151,7 @@ Foam::enhancementModels::thompsonTsouris::thompsonTsouris film, fluid, filmSpecieID, - bulkPatchID + bulkPatchID ), D1_(dimArea/dimTime/dimTemperature, massTransferModelCoeffs_.lookup("Dl1")), diff --git a/src/enhancementModels/thompsonTsouris/thompsonTsouris.H b/src/enhancementModels/thompsonTsouris/thompsonTsouris.H index e3ded50..aa46940 100644 --- a/src/enhancementModels/thompsonTsouris/thompsonTsouris.H +++ b/src/enhancementModels/thompsonTsouris/thompsonTsouris.H @@ -63,16 +63,17 @@ class thompsonTsouris //- 1st coefficient of Diffusivity of specie in liquid const dimensionedScalar D1_; - //- 2nd coefficient of Diffusivity of specie in liquid + //- 2nd coefficient of Diffusivity of specie in liquid const dimensionedScalar D2_; - volScalarField D_; + // Diffusivity + volScalarField D_; //- Time to turn enhancement on const scalar tStart_; - //- Instantaneous enhancement factor - volScalarField Einf_; + //- Instantaneous enhancement factor + volScalarField Einf_; //- Index of mass transfer patch in film mesh const label filmPatchID_; @@ -92,7 +93,7 @@ public: const solvers::multicomponentFilm& film, const solvers::multicomponentFluid& fluid, const label& filmSpecieID, - const label& bulkPatchID + const label& bulkPatchID ); diff --git a/src/interphaseMassTransferModels/physical/physical.C b/src/interphaseMassTransferModels/physical/physical.C index 8db2cdd..c2e8d56 100644 --- a/src/interphaseMassTransferModels/physical/physical.C +++ b/src/interphaseMassTransferModels/physical/physical.C @@ -104,7 +104,7 @@ Foam::interphaseMassTransferModels::physical::physical film_, fluid_, filmSpecieID_, - bulkPatchID_ + bulkPatchID_ ); } From 7ff6fa1c2f3a17ea59466a93a34ae54af5243dac Mon Sep 17 00:00:00 2001 From: Filipe Brandao Date: Thu, 30 Oct 2025 12:56:28 -0600 Subject: [PATCH 9/9] identation 2 --- .../filmPseudoFirstOrder/filmPseudoFirstOrder.C | 4 ++-- .../filmPseudoFirstOrder/filmPseudoFirstOrder.H | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.C b/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.C index 7ea367e..d943d39 100644 --- a/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.C +++ b/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.C @@ -56,9 +56,9 @@ Foam::enhancementModels::filmPseudoFirstOrder::filmPseudoFirstOrder typeName, dict, film, - fluid, + fluid, filmSpecieID, - bulkPatchID + bulkPatchID ), D1_(dimArea/dimTime/dimTemperature, diff --git a/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.H b/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.H index b199e46..d1a68cf 100644 --- a/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.H +++ b/src/enhancementModels/filmPseudoFirstOrder/filmPseudoFirstOrder.H @@ -90,9 +90,9 @@ public: ( const dictionary& dict, const solvers::multicomponentFilm& film, - const solvers::multicomponentFluid& fluid, + const solvers::multicomponentFluid& fluid, const label& filmSpecieID, - const label& bulkPatchID + const label& bulkPatchID );