Skip to content

Replace console.log/error with winston logger in approvalRoutes.js #653

Description

@nishupr

Bug Description

backend/routes/approvalRoutes.js uses console.log and console.error in 14 places while the rest of the backend uses the centralized Winston logger from utils/logger.js.

Evidence

Running Select-String on backend/routes/approvalRoutes.js reveals 14 console statement instances across:

  • Approval request creation → console.log, console.error
  • Approval fetch operations → console.error (3 instances)
  • Signature addition → console.log, console.error
  • Approval cancellation → console.log, console.error
  • History and stats → console.error (2 instances)
  • Recall/Contamination/Destroy requests → console.error (3 instances)

Impact

  • Approval workflow events not captured in logs/combined.log or logs/error.log
  • Multi-signature approval failures missed by production monitoring
  • Inconsistent logging format across the codebase

Proposed Fix

Import and use the Winston logger in approvalRoutes.js:

  • console.loglogger.info
  • console.errorlogger.error

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggssoc:approvedgssoc'26 approvedlevel:beginner20 pts for contributor 10 pts for mentortype:bug

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions