Fix for CTK cache problem

Author: mdboom

.github/actions/fetch_ctk/action.yml

@@ -185,8 +185,12 @@ runs:
         # Note: try to escape | and > ...
         tar -czvf ${CTK_CACHE_FILENAME} ${CACHE_TMP_DIR}
 
-        # "Move" files from temp dir to CUDA_PATH
-        CUDA_PATH="./cuda_toolkit"
+        # Populate the final CUDA_PATH directly (never stage through ./cuda_toolkit
+        # unconditionally — a second call with a different cuda-path would leave
+        # symlinks from a prerelease CTK at ./cuda_toolkit/include etc., causing
+        # "cp: cannot overwrite non-directory" failures on the next restore).
+        CUDA_PATH="${{ inputs.cuda-path }}"
+        rm -rf $CUDA_PATH
         mkdir -p $CUDA_PATH
         # Unfortunately we cannot use "rsync -av $CACHE_TMP_DIR/ $CUDA_PATH" because
         # not all runners have rsync pre-installed (or even installable, such as
@@ -209,7 +213,8 @@ runs:
       run: |
         ls -l
         CACHE_TMP_DIR="./cache_tmp_dir"
-        CUDA_PATH="./cuda_toolkit"
+        CUDA_PATH="${{ inputs.cuda-path }}"
+        rm -rf $CUDA_PATH
         mkdir -p $CUDA_PATH
         tar -xzvf $CTK_CACHE_FILENAME
         # Can't use rsync here, see above
@@ -220,12 +225,6 @@ runs:
           exit 1
         fi
 
-    - name: Move CTK to the specified location
-      if: ${{ inputs.cuda-path != './cuda_toolkit' }}
-      shell: bash --noprofile --norc -xeuo pipefail {0}
-      run: |
-        mv ./cuda_toolkit ${{ inputs.cuda-path }}
-
     - name: Set output environment variables
       shell: bash --noprofile --norc -xeuo pipefail {0}
       run: |