Skip to content

Commit 9f2d183

Browse files
committed
Use standard version parsing in release note resolution
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
1 parent 487855a commit 9f2d183

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

‎ci/tools/check_release_notes.py‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,11 @@ def _resolved_bindings_target(data: Mapping[str, object], git_tag: str) -> tuple
4444
package_root = bindings_config.parse_package_root(data.get("package_root"), "resolved package_root")
4545
raw_version = data.get("release_version")
4646
if not isinstance(raw_version, str):
47-
raise bindings_config.BindingsConfigError("resolved CUDA bindings package has no release_version")
48-
version = bindings_config.parse_pep440_version(raw_version, "resolved release_version")
47+
raise ValueError("resolved CUDA bindings package has no release_version")
48+
version = Version(raw_version)
4949
tag_version = bindings_config.parse_prefixed_version(git_tag, "v")
5050
if tag_version != version:
51-
raise bindings_config.BindingsConfigError(
52-
f"resolved CUDA bindings package does not match release tag {git_tag!r}"
53-
)
51+
raise ValueError(f"resolved CUDA bindings package does not match release tag {git_tag!r}")
5452
return package_root, version
5553

5654

@@ -96,7 +94,7 @@ def parse_version_from_tag(
9694

9795

9896
def is_post_release(version: str) -> bool:
99-
return bindings_config.parse_pep440_version(version, "release version").post is not None
97+
return Version(version).post is not None
10098

10199

102100
def notes_path(package: str, version: str) -> Path:
@@ -169,7 +167,7 @@ def main(argv: list[str] | None = None) -> int:
169167
if bindings_package is not None and not isinstance(bindings_package, dict):
170168
raise ValueError("resolved CUDA bindings package must be a JSON object")
171169
target = _release_target_from_tag(args.git_tag, args.component, bindings_package)
172-
except (bindings_config.BindingsConfigError, json.JSONDecodeError, ValueError) as error:
170+
except ValueError as error:
173171
print(f"ERROR: invalid CUDA bindings configuration: {error}", file=sys.stderr)
174172
return 2
175173
if target is None:

0 commit comments

Comments
 (0)