docs(messaging): clarify Slack token validation and slack policy preset (#4979)#4986
Open
abhi-0906 wants to merge 1 commit into
Open
docs(messaging): clarify Slack token validation and slack policy preset (#4979)#4986abhi-0906 wants to merge 1 commit into
abhi-0906 wants to merge 1 commit into
Conversation
…et (NVIDIA#4979) Signed-off-by: Abhimanyu Kumar <abhimanyukumar7290@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the intended Slack onboarding behavior that #4979 ran into: NemoClaw validates Slack tokens against the live Slack API during onboard, so invalid/placeholder tokens (
invalid_auth) cause the Slack channel to be skipped — and because theslacknetwork policy preset is only applied for channels that are actually enabled, the preset is not applied either (not shown as●inpolicy-list). Also points to the existingNEMOCLAW_SKIP_SLACK_AUTH_VALIDATION=1escape hatch for exercising Slack setup and theslackpreset with placeholder tokens in restricted/hermetic environments.Related Issue
Fixes #4979
Context
The current behavior is intentional and secure: live token validation prevents onboarding from enabling a channel with credentials Slack cannot use. The "fake-token test mode" the issue asks for already exists as
NEMOCLAW_SKIP_SLACK_AUTH_VALIDATION(documented in the commands reference). The gap was purely documentation — the consequence chain (invalid tokens → channel skipped →slackpreset not applied) and the skip-flag's role in policy-preset testing were not stated where Slack onboarding is documented. This is the reporter's "at minimum, document the mismatch" resolution; no behavior change.Changes
docs/manage-sandboxes/messaging-channels.mdx— in the Slack section, document that validation calls the live Slack API, that rejected tokens skip the channel and therefore do not apply theslackpreset, and thatNEMOCLAW_SKIP_SLACK_AUTH_VALIDATION=1skips the live probes for testing (format checks still apply).Type of Change
Verification
<name>sandbox placeholder and backtick-wrapped●conventions; new env/command references match the commands referencenpm run docs/ the docs link-check were not run on my Windows dev box (the link-check harness shells out in a way that fails locally); the change adds no links and is plain prose with inline code spans. Deferred to CI on Linux.