Skip to content

Change recursive functions to while loops #57

@bannanc

Description

@bannanc

Currently, adding "layers" or non-indexed atoms is done with a recursive method in the fragment_graphs and cluster_graphs. This is also true for making SMIRKS patterns for both new graphs here and ChemicalEnvironments. I tend to think that while loops are better (slightly less dangerous) than recursive methods. It would be nice to try to write these functions as loops instead of recursively.

Metadata

Metadata

Assignees

No one assigned

    Labels

    long termCaitlin did not have time to addressquestionNeeds to be explored further

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions