linstor: escape dashes in the LVM volume group name of snapshot paths

Device-mapper doubles every dash in both the volume group and the
logical volume name. getSnapshotPath only escaped the resource and
snapshot name, so on a VG like "linstor_pool-lvm-thin" the computed
/dev/mapper path did not exist and backing up a snapshot to secondary
storage failed with "qemu-img: Could not open".

Fixes apache#14011

(cherry picked from commit 9df44ce)

Author: rp-

plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/util/LinstorUtil.java

@@ -287,8 +287,10 @@ public static String getSnapshotPath(com.linbit.linstor.api.model.StoragePool sp
         switch (sp.getProviderKind()) {
             case LVM:  // thick LVM snapshot LVs use the same naming scheme as thin
             case LVM_THIN:
+                // device-mapper doubles every dash in the VG and LV name, so the VG part needs escaping too
+                final String vgName = backingPool.split("/")[0];
                 path = String.format("/dev/mapper/%s-%s_%s_%s",
-                    backingPool.split("/")[0], rscName.replace("-", "--"), suffix, snapshotName.replace("-", "--"));
+                    vgName.replace("-", "--"), rscName.replace("-", "--"), suffix, snapshotName.replace("-", "--"));
                 break;
             case ZFS:
             case ZFS_THIN:

plugins/storage/volume/linstor/src/test/java/org/apache/cloudstack/storage/datastore/util/LinstorUtilTest.java

@@ -126,6 +126,18 @@ public void testGetSnapshotPath() {
             String snapPath = LinstorUtil.getSnapshotPath(spLVM, "cs-cb32532a-dd8f-47e0-a81c-8a75573d3545", "cs-6c6b4e95");
             Assert.assertEquals(
                 "/dev/mapper/shared-cs--cb32532a--dd8f--47e0--a81c--8a75573d3545_00000_cs--6c6b4e95", snapPath);
+
+            // dashes in the volume group name must be escaped as well (GH issue #14011)
+            StoragePool spLVMThin = new StoragePool();
+            Properties lvmThinProps = new Properties();
+            lvmThinProps.put("StorDriver/StorPoolName", "linstor_pool-lvm-thin/thin");
+            spLVMThin.setProps(lvmThinProps);
+            spLVMThin.setProviderKind(ProviderKind.LVM_THIN);
+            String thinSnapPath = LinstorUtil.getSnapshotPath(spLVMThin,
+                "cs-12fc4055-3985-4025-8eb5-d6fd53effe37", "cs-d7aea646-5f40-46a2-b9dc-77e41ea29336");
+            Assert.assertEquals(
+                "/dev/mapper/linstor_pool--lvm--thin-cs--12fc4055--3985--4025--8eb5--d6fd53effe37_00000_cs--d7aea646--5f40--46a2--b9dc--77e41ea29336",
+                thinSnapPath);
         }
 
         {