Skip to content

Commit cfcedcc

Browse files
authored
Merge pull request #320 from Kyjor/bugfix/remove-asserts-from-precompile
Backport "Remove assertions in "src/precompile.jl" (#254)"
2 parents 73917f8 + 32a4edc commit cfcedcc

4 files changed

Lines changed: 16 additions & 17 deletions

File tree

‎.github/workflows/UnitTest.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
fail-fast: false
1717
matrix:
1818
julia-version: ['1.0', '1.6', '1', 'nightly']
19-
os: [ubuntu-latest, windows-latest, macos-13]
19+
os: [ubuntu-latest, windows-latest]
2020
julia-arch: [x64]
2121
include:
2222
- os: ubuntu-latest # only test one 32-bit job

‎.github/workflows/UnitTestArm.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
matrix:
2020
julia-version: ['1.0', '1.6', '1', 'nightly']
2121
os: [ubuntu-latest]
22-
distro: [ubuntu_latest]
22+
distro: [ubuntu24.04]
2323
arch: [aarch64]
2424

2525
steps:
@@ -51,8 +51,7 @@ jobs:
5151
mkdir -p /home/runner/work/julia/
5252
tar -xf /tmp/julia-aarch64.tar.gz --strip-components=1 -C /home/runner/work/julia/
5353
rm /tmp/julia-aarch64.tar.gz
54-
55-
- uses: uraimo/run-on-arch-action@v2.7.2
54+
- uses: uraimo/run-on-arch-action@v3
5655
name: Unit Test
5756
with:
5857
arch: ${{ matrix.arch }}

‎Project.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "FixedPointNumbers"
22
uuid = "53c48c17-4a7d-5ca2-90c5-79b7896eea93"
3-
version = "0.8.5"
3+
version = "0.8.6"
44

55
[deps]
66
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"

‎src/precompile.jl‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,27 @@ function _precompile_()
66
realtypes = (Float16, Float32, Float64, Int) # types for mixed Normed/Real operations
77
for T in normedtypes
88
for f in (+, -, abs, eps, rand) # unary operations
9-
@assert precompile(Tuple{typeof(f),T})
9+
precompile(Tuple{typeof(f),T})
1010
end
11-
@assert precompile(Tuple{typeof(rand),T,Tuple{Int}})
12-
@assert precompile(Tuple{typeof(rand),T,Tuple{Int,Int}})
11+
precompile(Tuple{typeof(rand),T,Tuple{Int}})
12+
precompile(Tuple{typeof(rand),T,Tuple{Int,Int}})
1313
for f in (trunc, floor, ceil, round) # rounding operations
14-
@assert precompile(Tuple{typeof(f),T})
15-
@assert precompile(Tuple{typeof(f),Type{Int},T})
14+
precompile(Tuple{typeof(f),T})
15+
precompile(Tuple{typeof(f),Type{Int},T})
1616
end
1717
for f in (+, -, *, /, <, <=, ==) # binary operations
18-
@assert precompile(Tuple{typeof(f),T,T})
18+
precompile(Tuple{typeof(f),T,T})
1919
for S in realtypes
20-
@assert precompile(Tuple{typeof(f),T,S})
21-
@assert precompile(Tuple{typeof(f),S,T})
20+
precompile(Tuple{typeof(f),T,S})
21+
precompile(Tuple{typeof(f),S,T})
2222
end
2323
end
2424
# conversions
2525
for S in realtypes
26-
@assert precompile(Tuple{Type{T},S})
27-
@assert precompile(Tuple{Type{S},T})
28-
@assert precompile(Tuple{typeof(convert),Type{T},S})
29-
@assert precompile(Tuple{typeof(convert),Type{S},T})
26+
precompile(Tuple{Type{T},S})
27+
precompile(Tuple{Type{S},T})
28+
precompile(Tuple{typeof(convert),Type{T},S})
29+
precompile(Tuple{typeof(convert),Type{S},T})
3030
end
3131
end
3232
end

0 commit comments

Comments
 (0)