Skip to content

Conversation

@ChenZiHong-Gavin
Copy link
Collaborator

@ChenZiHong-Gavin ChenZiHong-Gavin commented Dec 29, 2025

This PR refactors the environment variable loading mechanism which helps enhancing the robustness and clarity of parameter handling within the web UI component of the application.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ChenZiHong-Gavin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness and clarity of parameter handling within the web UI component of the application. It refactors the environment variable loading mechanism to a more logical location and explicitly defines critical backend storage parameters for graph and key-value operations. These changes ensure that the graph generation process, when initiated through the web interface, operates with the intended configurations and correctly persists its outputs, while also simplifying the Ray initialization logic.

Highlights

  • Environment Variable Loading Refactor: The loading of environment variables via load_dotenv() has been moved from graphgen/engine.py to graphgen/run.py. This centralizes environment variable loading to the application's main execution entry point, ensuring consistent setup.
  • WebUI Parameter Configuration: The web UI's graph generation process now explicitly configures the graph_backend to 'kuzu' and the kv_backend to 'rocksdb' within its global parameters. This ensures the correct storage technologies are used when running from the web interface.
  • Output Saving for Generate Operation: The generate operation within the web UI's configuration now includes "save_output": True, ensuring that the results of this operation are explicitly saved.
  • Streamlined Ray Initialization: Redundant Ray initialization checks and calls (ray.is_initialized() and ray.init()) have been removed from webui/app.py, streamlining the execution flow and relying on the Engine class or prior setup for Ray initialization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes parameter passing for the web UI and refactors environment variable loading. The changes correctly add missing parameters (save_output, graph_backend, kv_backend) needed for the Engine to run from the web UI. The redundant Ray initialization is also cleaned up. The logic of moving load_dotenv() to application entry points (run.py and webui/app.py) is sound.

I have one suggestion in webui/app.py to improve maintainability by replacing hardcoded backend names with constants.

Comment on lines +175 to +176
"graph_backend": "kuzu",
"kv_backend": "rocksdb",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The backend names kuzu and rocksdb are hardcoded here. For better maintainability, it's a good practice to define these as constants at the module level. This makes them easier to find, update, and reuse, and it also serves as documentation for the default choices.

For example, you could add this at the top of the file:

DEFAULT_GRAPH_BACKEND = "kuzu"
DEFAULT_KV_BACKEND = "rocksdb"

And then use these constants in the global_params dictionary.

@ChenZiHong-Gavin ChenZiHong-Gavin merged commit ffe827e into main Dec 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants