-
Notifications
You must be signed in to change notification settings - Fork 63
fix: fix params passing in webui #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ChenZiHong-Gavin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness and clarity of parameter handling within the web UI component of the application. It refactors the environment variable loading mechanism to a more logical location and explicitly defines critical backend storage parameters for graph and key-value operations. These changes ensure that the graph generation process, when initiated through the web interface, operates with the intended configurations and correctly persists its outputs, while also simplifying the Ray initialization logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes parameter passing for the web UI and refactors environment variable loading. The changes correctly add missing parameters (save_output, graph_backend, kv_backend) needed for the Engine to run from the web UI. The redundant Ray initialization is also cleaned up. The logic of moving load_dotenv() to application entry points (run.py and webui/app.py) is sound.
I have one suggestion in webui/app.py to improve maintainability by replacing hardcoded backend names with constants.
| "graph_backend": "kuzu", | ||
| "kv_backend": "rocksdb", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend names kuzu and rocksdb are hardcoded here. For better maintainability, it's a good practice to define these as constants at the module level. This makes them easier to find, update, and reuse, and it also serves as documentation for the default choices.
For example, you could add this at the top of the file:
DEFAULT_GRAPH_BACKEND = "kuzu"
DEFAULT_KV_BACKEND = "rocksdb"And then use these constants in the global_params dictionary.
This PR refactors the environment variable loading mechanism which helps enhancing the robustness and clarity of parameter handling within the web UI component of the application.