Compiler warnings

[StrikerTheHedgefox]

I get these compiler warnings when trying to compile anything with the nuklear.h header.

1>tfury_nuklear.c
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(5668,47): warning C5287: operands are different enum types 'nk_panel_set' and 'nk_panel_type'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(5669,42): warning C5287: operands are different enum types 'nk_panel_set' and 'nk_panel_type'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(5761,46): warning C5287: operands are different enum types 'nk_window_flags' and 'nk_panel_flags'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(6935,34): warning C4127: conditional expression is constant
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(10067,29): warning C4127: conditional expression is constant
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(29037,49): warning C5287: operands are different enum types 'nk_edit_types' and 'nk_edit_flags'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(30275,1): warning C4701: potentially uninitialized local variable 'text' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(30172,1): warning C4701: potentially uninitialized local variable 'sym_background' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\nuklear_console_label.h(78,1): warning C4700: uninitialized local variable 'handle' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\nuklear_console.h(1038,1): warning C4700: uninitialized local variable 'handle' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(23944,1): warning C4701: potentially uninitialized local variable 'label' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear\nuklear.h(25629,1): warning C4701: potentially uninitialized local variable 'text' used

[sleeptightAnsiC]

Would you mind retesting with latest master?

Line numbers don't match. Probably, because you have a bit older version.

I was able to track the first 5, and there's nothing wrong in these, but the later ones about uninitialized local variable might be important.

EDIT: moved this section to #958 (comment)

[StrikerTheHedgefox]

I think I have it up to date now?

1>tfury_nuklear.c
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(3727,37): warning C5287: operands are different enum types 'nk_edit_types' and 'nk_edit_flags'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(5642,47): warning C5287: operands are different enum types 'nk_panel_set' and 'nk_panel_type'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(5643,42): warning C5287: operands are different enum types 'nk_panel_set' and 'nk_panel_type'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(5735,46): warning C5287: operands are different enum types 'nk_window_flags' and 'nk_panel_flags'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(6909,34): warning C4127: conditional expression is constant
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(10041,29): warning C4127: conditional expression is constant
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(25961,53): warning C4244: '=': conversion from 'double' to 'float', possible loss of data
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(29007,49): warning C5287: operands are different enum types 'nk_edit_types' and 'nk_edit_flags'; use an explicit cast to silence this warning
1>(compiling source file 'backend/tfury_nuklear.c')
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(30142,1): warning C4701: potentially uninitialized local variable 'sym_background' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(30245,1): warning C4701: potentially uninitialized local variable 'text' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\nuklear_console_label.h(78,1): warning C4700: uninitialized local variable 'handle' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\nuklear_console.h(1038,1): warning C4700: uninitialized local variable 'handle' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(23918,1): warning C4701: potentially uninitialized local variable 'label' used
1>D:\sourcecode\TerminalFury\TerminalFury\core\backend\nuklear_console\vendor\Nuklear\nuklear.h(25603,1): warning C4701: potentially uninitialized local variable 'text' used

[sleeptightAnsiC]

checked on 5a54a9f

nuklear.h(5655,47): warning C5287: operands are different enum types 'nk_panel_set' and 'nk_panel_type'; use an explicit cast to silence this warning
nuklear.h(5656,42): warning C5287: operands are different enum types 'nk_panel_set' and 'nk_panel_type'; use an explicit cast to silence this warning

Nuklear/src/nuklear.h

Lines 5439 to 5440 in 5a54a9f

	NK_PANEL_SET_POPUP = NK_PANEL_SET_NONBLOCK|NK_PANEL_POPUP,
	NK_PANEL_SET_SUB = NK_PANEL_SET_POPUP|NK_PANEL_GROUP

nuklear.h(5748,46): warning C5287: operands are different enum types 'nk_window_flags' and 'nk_panel_flags'; use an explicit cast to silence this warning

Nuklear/src/nuklear.h

Line 5532 in 5a54a9f

NK_WINDOW_NOT_INTERACTIVE = NK_WINDOW_ROM|NK_WINDOW_NO_INPUT, /**< prevents all interaction caused by input to either window or widgets inside */

nuklear.h(6924,34): warning C4127: conditional expression is constant

Nuklear/src/nuklear_util.c

Line 87 in 5a54a9f

if (sizeof(unsigned int) > 2)

nuklear.h(10056,29): warning C4127: conditional expression is constant

Nuklear/src/nuklear_vertex.c

Lines 238 to 239 in 5a54a9f

	if(sizeof(nk_draw_index)==2) NK_ASSERT((list->vertex_count < NK_USHORT_MAX &&
	"To many vertices for 16-bit vertex indices. Please read comment above on how to solve this problem"));

nuklear.h(29022,49): warning C5287: operands are different enum types 'nk_edit_types' and 'nk_edit_flags'; use an explicit cast to silence this warning

Nuklear/src/nuklear_property.c

Line 280 in 5a54a9f

nk_do_edit(ws, out, edit, (int)NK_EDIT_FIELD|(int)NK_EDIT_AUTO_SELECT,

nuklear.h(23933) : warning C4701: potentially uninitialized local variable 'label' used

Nuklear/src/nuklear_text.c

Line 59 in 5a54a9f

nk_draw_text(o, label, (const char*)string, len, f, t->background, t->text);

nuklear.h(30260) : warning C4701: potentially uninitialized local variable 'text' used

Nuklear/src/nuklear_selectable.c

Line 64 in 5a54a9f

else nk_draw_symbol(out, sym, *icon, text.background, text.text, 1, font);

nuklear.h(30157) : warning C4701: potentially uninitialized local variable 'sym_background' used

Nuklear/src/nuklear_combo.c

Lines 334 to 335 in 5a54a9f

	nk_draw_symbol(&win->buffer, symbol, bounds, sym_background, symbol_color,
	1.0f, style->font);

[sleeptightAnsiC]

No, it was not, but I just reproduced it myself: https://godbolt.org/z/s8WoeEeY5

conditional expression is constant are bogus and don't appear in newer MSVC version. if(sizeof(nk_draw_index)==2) NK_ASSERT( can be fixed, but if (sizeof(unsigned int) > 2) cannot.

operands are different enum types are probably fine to ignore. Not sure, if we should cast them because it may create a mess. I'll check how the rest of library deals with it. EDIT: I don't see any casts in other enum definitions.

potentially uninitialized local variable might be actual bugs. There might be some branch being skipped. Memset'ing those variables to 0 will silence the warnings, but it's unwise.

[sleeptightAnsiC]

@StrikerTheHedgefox

Anyway, thanks. I may take a look into these someday.

Next time, please make sure to check against actual master and give more info about your setup (compiler version, flags, etc) Even though I know it's MSVC, it still took me some time to figure out what's going on.

[StrikerTheHedgefox]

I was using the nuklear submodule that came with nuklear_console, guess it wasn't up to date, apologies.

[RobLoach]

Ah, fixed! Thanks.

[sleeptightAnsiC]

@RobLoach wut? Why did you close this one?

[RobLoach]

Thought StrikerTheHedgefox updating his submodules fixed it 🤷 ... Still an issue?