there are several stuct fields with int types but bool semantics (and all kinds of integer shenanigans)

[sleeptightAnsiC]

This is a follow up from #883

Change the field type in nk_style_slider and nk_style_scrollbar to nk_bool.

I would rather not do this. Not only there are way more int fields with bool semantics like these two, there is simply no other use of nk_bool type anywhere in the style structs (EDIT: I think I found one somewhere). If you want these two changed, you should probably also change other similar fields elsewhere [...]

I may missing something, but I’m not entirely sure why this issue is being generalized to such a broad scope in the discussion. [...] broadening the problem to all similar cases, the conclusion naturally becomes that fixing it would be complex and risky. To me, this feels like a conceptual trap.

Those were the only ones that we had the code coverage to catch.

Nuklear/src/nuklear.h

Line 4642 in 25f33c8

int use_clipping;

Nuklear/src/nuklear.h

Line 5038 in 25f33c8

int show_buttons;

Nuklear/src/nuklear.h

Line 5134 in 25f33c8

int show_buttons;

Nuklear/src/nuklear.h

Line 5359 in 25f33c8

int cursor_visible;

Nuklear/src/nuklear.h

Line 5741 in 25f33c8

int use_pool;

^ Those are the ones I was able to quickly find. There are probably more.

I personally do NOT want to change any of this. It can cause more issues like #812 and this isn't affecting any new code anyway. I gave many reasons under #883 why changing any of those struct fields is risky.

I'm only reporting this for the sake of documenting. I will not be doing anything about it myself, and would suggest everyone else to ignore it, at least for now.

Edit: related to: #183 ; #185

[sleeptightAnsiC]

And also, for anyone who ever comes here: if you take a look at the structs in Nuklear, you will notice that most of the fields use wrong types in one way or another (for example: unsigned int instead of nk_uint/nk_uint32). So this isn't really only about nk_bool at this point (but the bool ones are the most obvious)

[RobLoach]

I think it does warrant cleaning up the data types. Understand that it could break compatibility, but honestly, a nk_bool should be used for boolean-cases 🙃

[sleeptightAnsiC]

Not exactly the same issue but very similar one: there are lots of enum types with only two members. Many of those are used in situations where simple bool would be fine. Most are nothing else than literal nk_bool alias:

Nuklear/src/nuklear.h

Line 285 in 859d17b

enum nk_modify {NK_FIXED = nk_false, NK_MODIFIABLE = nk_true};

Nuklear/src/nuklear.h

Lines 287 to 288 in 859d17b

	enum nk_collapse_states {NK_MINIMIZED = nk_false, NK_MAXIMIZED = nk_true};
	enum nk_show_states {NK_HIDDEN = nk_false, NK_SHOWN = nk_true};

Nuklear/src/nuklear.h

Line 1000 in 859d17b

enum nk_anti_aliasing {NK_ANTI_ALIASING_OFF, NK_ANTI_ALIASING_ON};

Nuklear/src/nuklear.h

Lines 4665 to 4668 in 859d17b

	enum nk_command_clipping {
	NK_CLIPPING_OFF = nk_false,
	NK_CLIPPING_ON = nk_true
	};

Nuklear/src/nuklear.h

Lines 4791 to 4794 in 859d17b

	enum nk_draw_list_stroke {
	NK_STROKE_OPEN = nk_false, /***< build up path has no connection back to the beginning */
	NK_STROKE_CLOSED = nk_true /***< build up path has a connection back to the beginning */
	};

Nuklear/src/nuklear_internal.h

Line 127 in 859d17b

enum {NK_DO_NOT_STOP_ON_NEW_LINE, NK_STOP_ON_NEW_LINE};

Nuklear/src/nuklear_internal.h

Lines 198 to 201 in 859d17b

	enum nk_window_insert_location {
	NK_INSERT_BACK, /* inserts window into the back of list (front of screen) */
	NK_INSERT_FRONT /* inserts window into the front of list (back of screen) */
	};

[sleeptightAnsiC]

There are few that use unsigned char but behave like boolean. In some cases char was used for getting specific padding and struct size, and I guess it may not be so trivial to swap it. I'm also pretty sure at least one of these came from STB, and there might be more in internal code.

Nuklear/src/nuklear.h

Lines 4080 to 4082 in e634a0d

	unsigned char ttf_data_owned_by_atlas; /**!< used inside font atlas: default to: 0*/
	unsigned char merge_mode; /**!< merges this font into the last font */
	unsigned char pixel_snap; /**!< align every character to pixel boundary (if true set oversample (1,1)) */

Nuklear/src/nuklear.h

Lines 4398 to 4402 in e634a0d

	unsigned char cursor_at_end_of_line;
	unsigned char initialized;
	unsigned char has_preferred_x;
	unsigned char single_line;
	unsigned char active;

Nuklear/src/nuklear.h

Lines 4727 to 4729 in e634a0d

	unsigned char grab;
	unsigned char grabbed;
	unsigned char ungrab;

Nuklear/src/nuklear.h

Line 5574 in e634a0d

unsigned char single_line;