Skip to content

Replace XOR thinking-collapse logic with intent-based expand/collapse #5847

Description

@Hmbown

crates/tui/src/tui/history.rs:435 computes collapsed = folded ^ !verbose ^ thinking_default_expanded. Triple-XOR inverts intent: verbose ON plus default-expanded ON renders collapsed, and explicitly folding while verbose renders expanded. Replace with intent logic (explicit fold wins; otherwise verbose or default-expanded expands), add a keyboard inline expand/collapse for thinking blocks (currently mouse-click only via ReasoningAction::Expand), and cover the truth table with unit tests. Work in progress on a fix branch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    • Status
      In progress

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions