Crash in Randomizer at Clanker's Cavern

[ssbmcortex]

Description of the crash:

I went to Clanker's Cavern, shot some eggs at his teeth to open the entrance, went inside, then went underwater. The moment I surfaced back up the game crashed.

Can you reproduce? If so please list the steps:

• No, I cannot reproduce this crash
• Yes, here are the steps to reproduce the crash:
• [ ]

Logs:

Lighthouse.log

System Information:

• OS: Linux (7.1.5-1-cachyos)
• GFX Backend: OpenGL
• Game Version: 1.0.1
• Rom Version: 1.0 NTSC

Additional Information:

Randomizer was enabled with everything shuffled (no junk items)

[JeodC]

Tracing the crash report, that Clanker room (inside his mouth) in vanilla has a function that spawns a ACTOR_46_JIGGY every frame that it doesn't exist. It burns a marker, so in rando when that actor is NOT ACTOR_46_JIGGY it keeps churning in an endless loop and floods the queue, leading to the actor array hitting its cap of 512. codeABC00_spawnJiggyAtLocation also bypasses the rando spawn override, so approaching the tooth from the wrong side will give you a vanilla jiggy instead of the intended check item.

• codeABC00_spawnJiggyAtLocationEx must consult VB_OVERRIDE_JIGGY_SPAWN, same as jiggy_spawn does.
• Make the rando "spawned" answer survive collection in the OnIsJiggyScoreSpawned listener, OR in RANDO_SAVE_CHECKS[randoCheckId].obtained alongside CheckSpawnedIdList, restoring the || jiggyscore_isCollected() semantics the cancel threw away.
• Do NOT null check in marker_init plus the warn/census, we want this class of bug to hard crash so we can fix it instead of scratching our heads wondering what's broken during a running rando session.

[Caladius]

This was already handled in WorldState using OnIsJiggyScoreSpawned. This behavior broke after merging into develop.

In CustomObject it also should not spawn if that specific RC has already been spawned.
ShouldCreateCustomActorEX handles not spawning duplicates.

[JeodC]

More conflict resolution bugs? Ew.