Skip to content

Commit fb14e22

Browse files
Fix clang-tidy findings in scheduler headers.
Remove redundant member init on WaitEntry::slot and explicitly delete Scheduler copy/move operations to satisfy cppcoreguidelines-special-member-functions. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 5f74b95 commit fb14e22

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

src/threading/scheduler/Group.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ namespace threading {
6868
/// token decrement, and the loser skips its own adjustment. This makes the
6969
/// keep/hand-back decision exact regardless of how many other waiters are parked,
7070
/// instead of inferring it from the (unreliable) emptiness of the wait buckets.
71-
std::shared_ptr<std::atomic<bool>> slot{};
71+
std::shared_ptr<std::atomic<bool>> slot;
7272
};
7373

7474
struct DrainResult {

src/threading/scheduler/Scheduler.hpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,11 @@ namespace threading {
5959
*/
6060
~Scheduler();
6161

62+
Scheduler(const Scheduler&) = delete;
63+
Scheduler(Scheduler&&) = delete;
64+
Scheduler& operator=(const Scheduler&) = delete;
65+
Scheduler& operator=(Scheduler&&) = delete;
66+
6267
/**
6368
* Starts the scheduler, and begins executing tasks.
6469
*

0 commit comments

Comments
 (0)