fix: resolve Clang-Tidy and MSVC CI failures in nuclearnet

Add missing includes and NOLINTs for Log.cpp, fix Fragmentation ctor casts
for MSVC, and move default multicast address to wire_protocol constant.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: TrentHouliston

src/nuclearnet/Log.cpp

@@ -22,14 +22,22 @@
 
 #include "Log.hpp"
 
+#include "../util/network/sock_t.hpp"
+#include "Discovery.hpp"
+
+#include <array>
+#include <atomic>
+#include <cstdint>
 #include <cstdio>
 #include <iostream>
+#include <string>
 
 namespace NUClear {
 namespace network {
 
 namespace {
 
+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
     std::atomic<std::uint8_t> g_log_level{static_cast<std::uint8_t>(LogLevel::Off)};
 
     const char* level_name(LogLevel level) {
@@ -61,9 +69,12 @@ namespace {
     }
 
     std::string hash_hex(uint64_t hash) {
-        char buf[19];
-        std::snprintf(buf, sizeof(buf), "0x%016llx", static_cast<unsigned long long>(hash));
-        return buf;
+        std::array<char, 19> buf{};
+        const int n = std::snprintf(buf.data(), buf.size(), "0x%016llx", static_cast<unsigned long long>(hash));
+        if (n < 0) {
+            return "0x?";
+        }
+        return std::string(buf.data(), static_cast<std::size_t>(n));
     }
 
     std::string sock_str(const util::network::sock_t& address) {

src/nuclearnet/NUClearNet.cpp

@@ -24,11 +24,13 @@
 
 #include <algorithm>
 #include <array>
+#include <cerrno>
 #include <chrono>
 #include <cstdint>
 #include <cstring>
 #include <memory>
 #include <set>
+#include <string>
 #include <system_error>
 #include <utility>
 #include <vector>
@@ -86,7 +88,9 @@ namespace {
 
     NUClearNet::NUClearNet()
         : discovery(std::make_unique<Discovery>(std::chrono::seconds(2)))
-        , fragmentation(std::make_unique<Fragmentation>(1452, 64 * 1024 * 1024, std::chrono::seconds(2)))
+        , fragmentation(std::make_unique<Fragmentation>(static_cast<uint16_t>(1452),
+                                                        static_cast<std::size_t>(64) * 1024 * 1024,
+                                                        std::chrono::seconds(2)))
         , reliability(std::make_unique<Reliability>()) {
         wire_discovery_callbacks();
     }
@@ -311,7 +315,7 @@ namespace {
                 open_sockets();
                 needs_rebind = false;
             }
-            catch (...) {
+            catch (...) {  // NOLINT(bugprone-empty-catch)
                 // Network not available yet; will retry on the next process() call
             }
 

src/nuclearnet/NUClearNet.hpp

@@ -41,6 +41,7 @@
 #include "PacketDeduplicator.hpp"
 #include "Reliability.hpp"
 #include "Routing.hpp"
+#include "wire_protocol.hpp"
 
 namespace NUClear {
 namespace network {
@@ -51,8 +52,8 @@ namespace network {
     struct NetworkConfig {
         /// This node's name on the network
         std::string name;
-        /// The multicast/broadcast/unicast address to announce on (organization-local multicast default)
-        std::string announce_address = "239.226.152.162";  // NOSONAR
+        /// The multicast/broadcast/unicast address to announce on
+        std::string announce_address = DEFAULT_ANNOUNCE_ADDRESS;
         /// The port to use for announce discovery
         in_port_t announce_port = 7447;
         /// Address to bind to (empty = all interfaces)

src/nuclearnet/wire_protocol.hpp

@@ -41,6 +41,9 @@ namespace network {
     /// Protocol version for NUClearNet v2
     constexpr uint8_t PROTOCOL_VERSION = 0x03;
 
+    /// Default organization-local multicast address for peer discovery (RFC 2365)
+    constexpr const char DEFAULT_ANNOUNCE_ADDRESS[] = "239.226.152.162";  // NOSONAR
+
     /// Packet type identifiers
     enum PacketType : uint8_t {
         ANNOUNCE = 1,