Surfaced while building the Unit R (#305) review's twin-binary fixture: mod_path from games.yaml is used verbatim everywhere; a relative value is resolved against the process CWD, not install_path. Identical on base and head (pre-existing).
Decide one of: (a) normalise — join a relative mod_path to install_path at load time (and document it); (b) reject — validate on load / lmm game add / lmm game detect and refuse relative values with a clear error. Either way lmm game detect must never write a relative mod_path. Check whether any code path today can produce one; if none can, (b) is the cheaper insurance.
Surfaced while building the Unit R (#305) review's twin-binary fixture:
mod_pathfromgames.yamlis used verbatim everywhere; a relative value is resolved against the process CWD, notinstall_path. Identical on base and head (pre-existing).Decide one of: (a) normalise — join a relative
mod_pathtoinstall_pathat load time (and document it); (b) reject — validate on load /lmm game add/lmm game detectand refuse relative values with a clear error. Either waylmm game detectmust never write a relativemod_path. Check whether any code path today can produce one; if none can, (b) is the cheaper insurance.