Skip malformed JUnit reports instead of failing

Author: Donnerbart

src/main/java/de/donnerbart/split/TestLoader.java

@@ -1,5 +1,6 @@
 package de.donnerbart.split;
 
+import com.fasterxml.jackson.core.JacksonException;
 import com.fasterxml.jackson.dataformat.xml.XmlMapper;
 import com.github.javaparser.JavaParser;
 import com.github.javaparser.ast.body.ClassOrInterfaceDeclaration;
@@ -75,7 +76,13 @@ public TestLoader(
                 var slowestTest = new TestCase("", Double.MIN_VALUE);
                 final var xmlMapper = new XmlMapper();
                 for (final var junitPath : junitPaths) {
-                    final var testSuite = xmlMapper.readValue(junitPath.toFile(), TestSuite.class);
+                    final TestSuite testSuite;
+                    try {
+                        testSuite = xmlMapper.readValue(junitPath.toFile(), TestSuite.class);
+                    } catch (final JacksonException e) {
+                        LOG.warn("Skipping malformed JUnit report {}: {}", junitPath, e.getOriginalMessage());
+                        continue;
+                    }
                     final var testCase = new TestCase(testSuite.getName(), testSuite.getTime());
                     if (classNames.contains(testCase.name())) {
                         if (testCases.add(testCase)) {

src/test/java/de/donnerbart/split/TestLoaderTest.java

@@ -139,6 +139,23 @@ void load_withJUnit_withMaxTestTime() throws Exception {
         assertThat(exitCode).hasNullValue();
     }
 
+    @Test
+    void load_withJUnit_withMalformedReport() throws Exception {
+        copyResourceToTarget(tmp.resolve("junit-reports"),
+                "reports/TEST-de.donnerbart.example.MalformedTest.xml",
+                "TEST-de.donnerbart.example.NoTimingOneTest.xml",
+                PERMISSIONS);
+
+        final var testCases = loadTests(true, NewTestTimeOption.ZERO);
+        assertThat(testCases).satisfiesExactlyInAnyOrder( //
+                testCase -> assertTestCase(testCase, new TestCase("de.donnerbart.example.FastTest", 2.374d)),
+                testCase -> assertTestCase(testCase, new TestCase("de.donnerbart.example.SlowTest", 12.386d)),
+                testCase -> assertTestCase(testCase, new TestCase("de.donnerbart.example.SlowestTest", 153.457d)),
+                testCase -> assertTestCase(testCase, new TestCase("de.donnerbart.example.NoTimingOneTest", 0d)),
+                testCase -> assertTestCase(testCase, new TestCase("de.donnerbart.example.NoTimingTwoTest", 0d)));
+        assertThat(exitCode).hasNullValue();
+    }
+
     @Test
     void load_whitespaceClassDefinition() throws Exception {
         final var projectFolder =

src/test/resources/reports/TEST-de.donnerbart.example.MalformedTest.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuite name="de.donnerbart.example.NoTimingOneTest" tests="1" skipped="0" failures="0" errors="0"
+           timestamp="2025-01-01T00:00:00" hostname="example" time="99.999">
+    <properties/>
+    <testcase name="testMethod()"
+              classname="de.donnerbart.example.NoTimingOneTest" time="99.999">
+    <system-out><![CDATA[]]></system-out>
+    <system-err><![CDATA[]]></system-err>
+</testsuite>
+tail of a previous report version
+</testsuite>