review: validate GTEST_ARCH against the allowed spellings

Author: jbachorik

.gitlab/scripts/run-gtest-quarantine.sh

@@ -40,6 +40,12 @@ case "${SANITIZER_LC}" in
   asan|tsan|release) ;;
   *) echo "SANITIZER_LC must be one of: asan, tsan, release (got '${SANITIZER_LC}')" >&2; exit 1 ;;
 esac
+# GTEST_ARCH builds the quarantine cell string; a runner-tag spelling (arm64)
+# or typo would match no entry and silently mute nothing on that job.
+case "${GTEST_ARCH}" in
+  amd64|aarch64) ;;
+  *) echo "GTEST_ARCH must be one of: amd64, aarch64 (got '${GTEST_ARCH}')" >&2; exit 1 ;;
+esac
 
 HERE=$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" &> /dev/null && pwd)
 REPO_ROOT=$(cd "${HERE}/../.." && pwd)

.gitlab/scripts/tests/test_run_gtest_quarantine.sh

@@ -268,6 +268,20 @@ else
   pass "T14 the rejected value never touches the results path"
 fi
 
+# T18 — a miswired GTEST_ARCH (e.g. the runner tag's arm64) must fail loudly:
+# the cell string it would build matches no quarantine entry and mutes
+# nothing silently.
+OUT=$( cd "${WORK}/repo" && \
+  env SANITIZER_LC=asan GTEST_ARCH=arm64 \
+    bash .gitlab/scripts/run-gtest-quarantine.sh 2> "${STDERR_FILE}" )
+RC=$?
+assert_rc 1 "T18 GTEST_ARCH=arm64 exits 1"
+if grep -q "must be one of: amd64, aarch64" "${STDERR_FILE}"; then
+  pass "T18 stderr names the allowed arch spellings"
+else
+  fail "T18: stderr missing the arch message, got: $(cat "${STDERR_FILE}")"
+fi
+
 # T15 — the selector must anchor on the config directory: a "release_helper"
 # binary parked in an asan_other directory must not be swept into the
 # release cell. (The counterpart — an unprefixed binary inside a release_*