system-probe(-lite): log and graceful exit on unwritable system-probe socket paths

[Yumasi]

What does this PR do?

This PR adds more explicit logging & graceful exit to SP/SPL.

When the socket path is not writable, SP/SPL will now:

• Log the issue explicitly, with suggestion to change the socket path to a writable path.
• Exit with a status 0, to prevent unwanted restart loops.

Motivation

Part of resolution of AGENT-16332: with the recent default enablement of discovery and SPL, SPL was found crashing on ECS fargate due to the socket path not being writable.

It was suggested to make system-probe(-lite) exit more gracefully in that case, and with a more explicit log message, which this PR adds to both SP & SPL.

Describe how you validated your changes

Unit tests

Additional Notes

[github-actions]

@codex review

[datadog-official]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

DataDog/datadog-agent | tests_windows-x64     

Label analysis | release-note-check     

Label analysis | skip-qa-check     

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 7.14%
• Overall Coverage: 50.62% (-4.50%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ff37f69 | Docs | Datadog PR Page | Give us feedback!}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff37f69b7c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Limit socket-path handling to listener errors

When the socket itself is writable but a later startup step fails with EACCES/EPERM (for example an enabled eBPF module causes api.StartServer to return module.Register/ebpf.Setup permission errors after the listener is created), this branch treats the error as an unwritable socket path, logs the socket guidance, and returns nil so the process exits 0. That silently disables system-probe instead of surfacing a real module startup failure; the graceful-exit classification should only apply to errors from creating/removing/chmodding the listener.

Useful? React with 👍 / 👎.

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 7da169bc:

Results for datadog-agent_7.81.0~devel.git.677.ff37f69.pipeline.118060056-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7da169b
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64_fips	+4.0 KiB (0.00% increase, -0.19% of buffer)	707.749 → 707.753 → 709.840
✅	agent_rpm_amd64_fips	+4.0 KiB (0.00% increase, -0.19% of buffer)	707.733 → 707.737 → 709.840
✅	agent_suse_amd64_fips	+4.0 KiB (0.00% increase, -0.19% of buffer)	707.733 → 707.737 → 709.840

30 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	751.998 MiB
✅	agent_heroku_amd64	310.668 MiB
✅	agent_msi	617.515 MiB
✅	agent_rpm_amd64	751.982 MiB
✅	agent_rpm_arm64	727.382 MiB
✅	agent_rpm_arm64_fips	686.830 MiB
✅	agent_suse_amd64	751.982 MiB
✅	agent_suse_arm64	727.382 MiB
✅	agent_suse_arm64_fips	686.830 MiB
✅	docker_agent_amd64	811.437 MiB
✅	docker_agent_arm64	811.854 MiB
✅	docker_agent_jmx_amd64	1002.380 MiB
✅	docker_agent_jmx_arm64	991.447 MiB
✅	docker_cluster_agent_amd64	209.759 MiB
✅	docker_cluster_agent_arm64	222.849 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.849 MiB
✅	docker_dogstatsd_arm64	37.946 MiB
✅	docker_host_profiler_amd64	304.782 MiB
✅	docker_host_profiler_arm64	315.917 MiB
✅	dogstatsd_deb_amd64	30.507 MiB
✅	dogstatsd_deb_arm64	28.507 MiB
✅	dogstatsd_rpm_amd64	30.507 MiB
✅	dogstatsd_suse_amd64	30.507 MiB
✅	iot_agent_deb_amd64	45.790 MiB
✅	iot_agent_deb_arm64	42.504 MiB
✅	iot_agent_deb_armhf	43.302 MiB
✅	iot_agent_rpm_amd64	45.790 MiB
✅	iot_agent_suse_amd64	45.789 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8a11beaa-5993-48e3-84dc-b5be740c4909

Baseline: 7da169b
Comparison: ff37f69
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	-0.18	[-1.25, +0.88]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.27	[-0.33, -0.22]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.55	[-0.81, -0.29]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.58	[-0.62, -0.55]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	146.02MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	733.85KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	479.13MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	179.71MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.35MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	344.09 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	394.28MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[dd-octo-sts]

This pull request has been automatically marked as stale because it has not had activity in the past 15 days.

It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.

Thank you for your contributions!

[dd-octo-sts]

This pull request was automatically closed because it has been stale for 15 days with no activity.

If this pull request is still relevant, please reopen it or create a new pull request with updated information.

Thanks!