-
Notifications
You must be signed in to change notification settings - Fork 363
Open
Labels
feature request 📬A request for new changes to improve functionalityA request for new changes to improve functionality
Description
Overview
Compared to MVVM Light, RelayCommand has a major (undocumented) breaking change as it doesn't seem to integrate with CommandManager - as a result, their CanExecuteChanged event doesn't fire automatically anymore, which broke tons of functionality in our app.
In order to fix the issue, my approach would have been to subclass RelayCommand and subscribe to CommandManager, but the class is sealed. Not sure I see a reason for this - wouldn't it make sense to unseal the class? I've had use cases before where I would have appreciated that already in order to provide hooks.
API breakdown
- If possible, update https://learn.microsoft.com/en-us/dotnet/communitytoolkit/mvvm/migratingfrommvvmlight
- Unseal RelayCommand implementations
Metadata
Metadata
Assignees
Labels
feature request 📬A request for new changes to improve functionalityA request for new changes to improve functionality