Remove ThemeListener? And/or refactor?

ThemeListener doesn't work in the Windows App SDK at the moment, so thinking we should remove it for now until it's supported in the WASDK?

In either case, we should refactor to remove the call to EnqueueAsync for the DispatcherQueue Extensions so we don't need the Helper package to depend on the Extensions package. I think that's the only call there:

Windows/components/Helpers/src/ThemeListener.cs

Lines 110 to 123 in be4577e

    
                   return DispatcherQueue.EnqueueAsync( 
        
                       () => 
        
                       { 
        
                           // TODO: This doesn't stop the multiple calls if we're in our faked 'White' HighContrast Mode below. 
        
                           if (CurrentTheme != Application.Current.RequestedTheme || 
        
                               IsHighContrast != _accessible.HighContrast) 
        
                           { 
        
           #if DEBUG 
        
                               global::System.Diagnostics.Debug.WriteLine("Color Values Changed"); 
        
           #endif 
        
                               UpdateProperties(); 
        
                           } 
        
                       }, DispatcherQueuePriority.Normal);

Seems to be the only use of the Extensions I believe in this project. (which also means the Collections package is pulling them in as they depend on the Helpers)

Is themelistener still needed? I thought things like this got more and more built in...

Again: could it be that something is blocking the basic functionality? (things like) Theme adaptation should be as native as possible and I am convinced there's no need for a complex solution.

Navigation Menu

Repository navigation

Remove ThemeListener? And/or refactor? #135

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	return DispatcherQueue.EnqueueAsync(
	() =>
	{
	// TODO: This doesn't stop the multiple calls if we're in our faked 'White' HighContrast Mode below.
	if (CurrentTheme != Application.Current.RequestedTheme \|\|
	IsHighContrast != _accessible.HighContrast)
	{
	#if DEBUG
	global::System.Diagnostics.Debug.WriteLine("Color Values Changed");
	#endif

	UpdateProperties();
	}
	}, DispatcherQueuePriority.Normal);

Remove ThemeListener? And/or refactor? #135

Description

Activity

Jay-o-Way commented on Dec 14, 2023

Jay-o-Way commented on Jul 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions