Repository navigation
Commit 036485a
committed
Fix: Delete SearchState.replaceRange, which was dead and thread-unsafe
The method had no callers anywhere in the repo, was internal to CESearch
so nothing outside could reach it, witnessed no protocol requirement,
and was not @objc, so no dynamic dispatch could find it either.
It also built an NSAlert and called runModal() from a synchronous
nonisolated method on a nonisolated class, which presents a modal alert
from an arbitrary thread. Xcode 26 accepts this; the CI runner's Xcode
16.4 rejects it, correctly.
The three other NSAlert sites in the packages all sit on @mainactor
types and are unaffected. Removing this one leaves the file with no
AppKit dependency, so that import goes too: its only other NS use,
NSString.CompareOptions, is Foundation.1 parent 87b373d commit 036485a
1 file changed
Lines changed: 0 additions & 58 deletions
Lines changed: 0 additions & 58 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
107 | 106 | | |
108 | 107 | | |
109 | 108 | | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | 109 | | |
168 | 110 | | |
169 | 111 | | |
| |||
0 commit comments