[Bug] Account login fails due to case-sensitivity in email field

[ryvione]

Content

There is an issue where the application fails to authenticate an account if the email address contains uppercase letters. Even when the password is correct, the application returns a login error or crashes unless the email is entered entirely in lowercase.

Steps to Reproduce

1. Open the application.
2. Enter a valid email address using mixed-case letters (e.g., AccOuNT@emaIL.Com).
3. Enter the correct password associated with that account.
4. Attempt to sign in.

Expected Behavior

The application should treat the email address as case-insensitive and successfully log the user in, or automatically convert the input to lowercase before processing.

Actual Behavior

The application fails to recognize the account, reporting an incorrect password.

Workaround

Manually entering the email address in all lowercase letters (e.g., account@email.com) allows the login to proceed successfully.

[CLARATION]

What version are you using?

[ryvione]

I'm using the latest version

[CLARATION]

There code does automatically lowercase here https://github.com/CLARATION/Impactor/blob/main/crates/plume_core/src/auth/account/login.rs#L114 not sure if it even works properly though

[ryvione]

I'll test it again to be sure

[ryvione]

Yeah it's not working, I checked the code in its integrity and you can try to make those changes:

In login_email_pass, the lowercased username (username_for_spd) is correctly created at the top of the function, but the original mixed-case username is still being passed to srp_client.process_reply and since SRP uses the username as part of its crypto, this causes a key mismatch when the email has any uppercase letters

The fix is just swapping username.as_bytes() for username_for_spd.as_bytes() in the process_reply

Hope it'll work!

[CLARATION]

PR's are welcome.

[ryvione]

Okay, done