fix(sdk-lib-mpc): add keyShare to EdDSA MPCv2 getReducedKeyShare#8746
Merged
Conversation
getReducedKeyShare() was only serialising sharePk (the 32-byte public key) into the CBOR keycard payload, silently discarding the opaque WASM signing key share and chain code. Recovery signing via DSG requires the full keyShare buffer as input to ed25519_dsg_round0_process, making the old format unusable for SDK-local hot-wallet recovery. ReducedKeyShareType now includes keyShare, pub, and rootChainCode, matching the pattern of ECDSA MPCv2's ReducedKeyShare. Tests updated to assert all three fields are present and correct. Ticket: WCI-385
mohammadalfaiyazbitgo
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getReducedKeyShare() was only serialising sharePk (the 32-byte public key) into the CBOR keycard payload, silently discarding the opaque WASM signing key share and chain code. Recovery signing via DSG requires the full keyShare buffer as input to ed25519_dsg_round0_process, making the old format unusable for SDK-local hot-wallet recovery.
ReducedKeyShareType now includes keyShare, pub, and rootChainCode, matching the pattern of ECDSA MPCv2's ReducedKeyShare. Tests updated to assert all three fields are present and correct.
Ticket: WCI-385