feat(sdk-core): implement EdDSA MPCv2 external signer orchestrator#8744
Draft
bitgo-ai-agent-dev[bot] wants to merge 2 commits into
Draft
feat(sdk-core): implement EdDSA MPCv2 external signer orchestrator#8744bitgo-ai-agent-dev[bot] wants to merge 2 commits into
bitgo-ai-agent-dev[bot] wants to merge 2 commits into
Conversation
Implement signEddsaMPCv2TssUsingExternalSigner in EddsaMPCv2Utils, replacing the stub in baseTSSUtils. Also wire up the wallet.ts dispatch block and private signTransactionTssExternalSignerEdDSAMPCv2 method so the calling code and implementation land together. - EddsaMPCv2Utils.signEddsaMPCv2TssUsingExternalSigner: full 3-round orchestration using caller-supplied generator functions, pickBitgo- PubGpgKeyForSigning with isEddsaMpcv2=true, and armored BitGo GPG key passed to round 2/3 generators. Asserts signatureShares after round 2, mirrors ECDSA counterpart. - wallet.ts: adds dispatch block for customEddsaMPCv2Signing* params before existing ECDSA MPCv2 block; adds private signTransactionTssExternalSignerEdDSAMPCv2 method. - Unit tests: 5 cases covering happy path, string txRequestId resolution, missing round-2 signatureShares assert, message-signing rejection, and armored key delivery to generators. Ticket: WCI-374 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Session-Id: 68742945-d54f-4fb6-a866-47a802ad253e Task-Id: bb6a6972-cbe9-43f2-a9c3-74eefc045a44
bitgo-ai-agent-dev
Bot
force-pushed
the
WCI-374/eddsa-mpcv2-external-signer-orchestrator
branch
from
1678a2d to
ae9684c
Compare
@types/mocha does not accept a string as the first argument to before() and beforeEach(); drop the descriptive titles to fix the TS2345 compile error. Ticket: WCI-374 Session-Id: 68742945-d54f-4fb6-a866-47a802ad253e Task-Id: bb6a6972-cbe9-43f2-a9c3-74eefc045a44
bitgo-ai-agent-dev
Bot
force-pushed
the
WCI-374/eddsa-mpcv2-external-signer-orchestrator
branch
from
b7ed415 to
2910b20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signEddsaMPCv2TssUsingExternalSignerinEddsaMPCv2Utils, replacing the stub inbaseTSSUtils. Full 3-round orchestration using caller-supplied generator functions, withpickBitgoPubGpgKeyForSigning(isEddsaMpcv2=true)and armored BitGo GPG key passed to round 2/3 generators.wallet.tssignTransactionforcustomEddsaMPCv2Signing*params (placed before existing ECDSA MPCv2 block), plus privatesignTransactionTssExternalSignerEdDSAMPCv2method.Depends on: WCI-373 (types + stub — already merged)
Scope: WCI-165
Test plan
modules/sdk-core/test/unit/bitgo/utils/tss/eddsa/eddsaMPCv2Utils.tscover the 5 cases listed aboveyarn unit-test --scope @bitgo/sdk-corepasses in CIcustomEddsaMPCv2Signing*functions route tosignTransactionTssExternalSignerEdDSAMPCv2, not the ECDSA pathTicket: WCI-374
🤖 Generated with Ralph