Skip to content

Settings: URLs remembered from video prompt do not appear in Trusted URLs list #894

Description

@minetake01

Describe the bug?

When a user approves a video URL with Remember enabled in the URL prompt, the saved trust entry does not appear in Settings → Downloads & URLs, and there is no way to remove that entry from the list UI.

The URL List section only shows built-in default patterns (e.g. a read-only field labeled Trusted URLs showing a count such as 13 URL(s)). The remembered entry is missing, so per-row delete (Click to remove / Remove Trusted URL) is unavailable for it.

The settings layout also uses overlapping labels (Trusted URLs, URL List) that suggest more than one list, while the runtime only uses a single store (BasisTrustedUrls / trustedUrls.json).

Steps to Reproduce

  1. In a world, trigger a video URL load that is not covered by the built-in default trust patterns (an https:// URL from a host outside the default list).
  2. In the URL approval prompt, turn Remember on and approve the URL.
  3. Open Settings → Downloads & URLs.
  4. Scroll to the Trusted URLs area and inspect URL List.

The expected behavior

  • The pattern saved by the Remember action (full URL or wildcard, depending on scope) appears in the list UI.
  • The user can remove that entry from settings (per-row delete and/or Clear All Trusted URLs).

Screenshots

Image Image

Build Info

Version: 2.0.1
Unity: 6000.4.11f1
Platform: WindowsPlayer
Mode: Desktop
Build GUID: 9ceddc5ee8844fc0be2deb1b06289058

Log Files

N/A

Additional Context

Localization mismatch (same feature, different framing)

The section uses one localization key (settings.trustedUrls.title) but the wording differs by language:

Language Section title (settings.trustedUrls.title)
English Trusted URLs (no “video”)
Japanese 信頼済み動画URL
Many others (e.g. fr, nl, ru, zh) Title includes “video”

English settings.trustedUrls.description also describes broader scope (“images, videos, and text content”), while only VideoPlayerShim reads/writes BasisTrustedUrls today. This can make the settings UI imply a general URL list or a separate “video URL list” when there is actually a single store.

Current UI structure (single data store, multiple labels)

English UI label Role today
Trusted URLs Section title (settings.trustedUrls.title)
Trusted URLs + field showing {N} URL(s) Read-only count (settings.trustedUrls.count.title / settings.trustedUrls.count) — looks like an input, is not editable
Add Trusted URL Manual add form — always shown (settings.trustedUrls.add.title)
URL List Deletable pattern buttons (settings.trustedUrls.list.title)

The same BasisTrustedUrls.GetAll() result feeds both the count and URL List, but the layout reads like separate areas.

settings.trustedUrls.description exists in localization but is never shown in SettingsProviderTrustedUrls.Populate().

Proposed direction

unify one list + fix visibility

  1. Standardize on Trusted URLs across section title, count, add form, and list (and align localization so titles/descriptions match actual behavior).
  2. Section the unified list into Built-in (from BasisDefaultTrustedUrls) and Added by you (Remember + manual add).
  3. Fix Remember → settings visibility: entries saved when RememberChoice is true must appear under Added by you (when not identical to a built-in pattern).
  4. Make the {N} URL(s) count clearly read-only.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions