From dd2dab690fa3c59fa0081b31ba5d0a76a6df2364 Mon Sep 17 00:00:00 2001 From: Sonic Build Admin Date: Thu, 17 Sep 2026 16:04:17 +0000 Subject: [PATCH] [radius] skip RADIUS tests on BMC topologies ### Why i did it ? The RADIUS suite ran on BMC by accident. It is marked topology("any") and was never opted into the BMC topologies, but the test runner passes --topology bmc-shared-mgmt,any and check_topology does a literal membership test, so the "any" element matches. ### how i did it? Two of the six cases depend on a routing stack that a BMC does not have by design (no bgp container, no /usr/bin/rvtysh): - test_radius_command_auth asserts "show ip route" is authorized; as a RADIUS RO user the sudo escalation is rejected first, surfacing a misleading "not authorized" failure - test_radius_source_ip needs a routed interface and "show ip route json", its existing skip guard never fires because routed_interfaces accepts the management interface - tests/radius/ is not in the BMC-compatible suite list in docs/testplan/bmc/BMC-high-level-test-plan.md - Add a directory-level conditional_mark entry, matching the adjacent precedent, so both current and future radius tests are skipped on BMC. ### How to verify? - run sonic mgmt test for bmc Summary: Fixes # (issue) ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 - [ ] 202512 - [ ] 202605 Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): Failure type: ### Tested branch - [ ] master - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 - [ ] 202512 - [ ] 202605 - [ ] N/A ### Test result ### Approach #### What is the motivation for this PR? #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation Signed-off-by: Sonic Build Admin --- .../conditional_mark/tests_mark_conditions.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml b/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml index d8069ed11..950e5224a 100644 --- a/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml +++ b/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml @@ -4647,6 +4647,16 @@ qos/test_voq_watchdog.py: conditions: - "asic_type not in ['cisco-8000']" +####################################### +##### radius ##### +####################################### + +radius/: + skip: + reason: 'RADIUS tests require routing and switch CLI, not available on BMC' + conditions: + - "'bmc' in topo_type" + ####################################### ##### radv ##### #######################################