fix(lsp): honor per-server formatting toggle

Author: bajrangCoder

src/cm/lsp/clientManager.ts

@@ -60,13 +60,6 @@ function safeString(value: unknown): string {
 	return value != null ? String(value) : "";
 }
 
-const defaultKeymaps = keymap.of([
-	...formatKeymap,
-	...acodeRenameKeymap,
-	...jumpToDefinitionKeymap,
-	...findReferencesKeymap,
-]);
-
 interface BuiltinExtensionsResult {
 	extensions: Extension[];
 	diagnosticsExtension: Extension | LSPClientExtension | null;
@@ -83,14 +76,25 @@ function buildBuiltinExtensions(
 		diagnostics: includeDiagnostics = true,
 		inlayHints: includeInlayHints = true,
 		documentHighlights: includeDocumentHighlights = true,
+		formatting: includeFormatting = true,
 	} = config;
 
 	const extensions: Extension[] = [];
 	let diagnosticsExtension: Extension | LSPClientExtension | null = null;
 
 	if (includeCompletion) extensions.push(serverCompletion());
 	if (includeHover) extensions.push(hoverTooltips());
-	if (includeKeymaps) extensions.push(defaultKeymaps);
+	if (includeKeymaps) {
+		const bindings = [
+			...(includeFormatting ? formatKeymap : []),
+			...acodeRenameKeymap,
+			...jumpToDefinitionKeymap,
+			...findReferencesKeymap,
+		];
+		if (bindings.length) {
+			extensions.push(keymap.of(bindings));
+		}
+	}
 	if (includeSignature) extensions.push(signatureHelp());
 	if (includeDiagnostics) {
 		const diagExt = serverDiagnostics();
@@ -263,6 +267,7 @@ export class LspClientManager {
 		if (!servers.length) return false;
 
 		for (const server of servers) {
+			if (!supportsBuiltinFormatting(server)) continue;
 			try {
 				const context: RootUriContext = {
 					uri: normalizedUri,
@@ -912,6 +917,10 @@ function resolveIndentWidth(unit: string): number {
 	return width || 4;
 }
 
+function supportsBuiltinFormatting(server: LspServerDefinition): boolean {
+	return server.clientConfig?.builtinExtensions?.formatting !== false;
+}
+
 const defaultManager = new LspClientManager();
 
 export default defaultManager;

src/cm/lsp/formatter.ts

@@ -3,13 +3,17 @@ import { getModes } from "cm/modelist";
 import toast from "components/toast";
 import lspClientManager from "./clientManager";
 import serverRegistry from "./serverRegistry";
-import type { AcodeApi, FileMetadata } from "./types";
+import type { AcodeApi, FileMetadata, LspServerDefinition } from "./types";
 
 interface Mode {
 	name?: string;
 	extensions?: string;
 }
 
+function supportsBuiltinFormatting(server: LspServerDefinition): boolean {
+	return server?.clientConfig?.builtinExtensions?.formatting !== false;
+}
+
 interface EditorManagerWithLsp {
 	editor?: EditorView;
 	activeFile?: AcodeFile;
@@ -32,6 +36,7 @@ function getActiveMetadata(
 export function registerLspFormatter(acode: AcodeApi): void {
 	const languages = new Set<string>();
 	serverRegistry.listServers().forEach((server) => {
+		if (!supportsBuiltinFormatting(server)) return;
 		(server.languages || []).forEach((lang) => {
 			if (lang) languages.add(String(lang));
 		});
@@ -56,7 +61,9 @@ export function registerLspFormatter(acode: AcodeApi): void {
 				toast("Unknown language for LSP formatting");
 				return false;
 			}
-			const servers = serverRegistry.getServersForLanguage(languageId);
+			const servers = serverRegistry
+				.getServersForLanguage(languageId)
+				.filter(supportsBuiltinFormatting);
 			if (!servers.length) {
 				toast("No LSP formatter available");
 				return false;

src/cm/lsp/types.ts

@@ -145,6 +145,7 @@ export interface BuiltinExtensionsConfig {
 	diagnostics?: boolean;
 	inlayHints?: boolean;
 	documentHighlights?: boolean;
+	formatting?: boolean;
 }
 
 export interface AcodeClientConfig {